You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/07/16 21:45:48 UTC

Review Request 23563: Added support for installing stout headers.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23563/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Timothy St. Clair.


Bugs: MESOS-1608
    https://issues.apache.org/jira/browse/MESOS-1608


Repository: mesos-git


Description
-------

Ripped off from Tim St. Clair's branch at https://github.com/timothysc/mesos/commit/86c212197d56c4897acbe09617b696eb496e14f2


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am b562e870b05915878b4e7e771b89bee3ecc114e7 
  3rdparty/libprocess/3rdparty/stout/configure.ac 86e1ff369bdcf1056bf2ce7606aa3c910e699173 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am PRE-CREATION 

Diff: https://reviews.apache.org/r/23563/diff/


Testing
-------

make distcheck

make install DESTDIR=/tmp/mesos-install


Thanks,

Vinod Kone

Re: Review Request 23563: Added support for installing stout headers.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23563/#review48128
-----------------------------------------------------------

Ship it!


At some later point maybe we add a Makefile to mesos/include too? ;-)

- Benjamin Hindman


On July 17, 2014, 10:18 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23563/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 10:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1608
>     https://issues.apache.org/jira/browse/MESOS-1608
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Ripped off from Tim St. Clair's branch at https://github.com/timothysc/mesos/commit/86c212197d56c4897acbe09617b696eb496e14f2
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am b562e870b05915878b4e7e771b89bee3ecc114e7 
>   3rdparty/libprocess/3rdparty/stout/configure.ac 86e1ff369bdcf1056bf2ce7606aa3c910e699173 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23563/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> make install DESTDIR=/tmp/mesos-install
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 23563: Added support for installing stout headers.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23563/
-----------------------------------------------------------

(Updated July 17, 2014, 10:18 p.m.)


Review request for mesos, Benjamin Hindman and Timothy St. Clair.


Changes
-------

added a comment per benh's suggestion.


Bugs: MESOS-1608
    https://issues.apache.org/jira/browse/MESOS-1608


Repository: mesos-git


Description
-------

Ripped off from Tim St. Clair's branch at https://github.com/timothysc/mesos/commit/86c212197d56c4897acbe09617b696eb496e14f2


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am b562e870b05915878b4e7e771b89bee3ecc114e7 
  3rdparty/libprocess/3rdparty/stout/configure.ac 86e1ff369bdcf1056bf2ce7606aa3c910e699173 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am PRE-CREATION 

Diff: https://reviews.apache.org/r/23563/diff/


Testing
-------

make distcheck

make install DESTDIR=/tmp/mesos-install


Thanks,

Vinod Kone

Re: Review Request 23563: Added support for installing stout headers.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23563/#review47945
-----------------------------------------------------------


What's the benefit of the extra Makefile? Why not just keep one Makefile but add the extra HEADERS definition? Seems more complicated, so maybe there is something I'm missing, which should probably be documented. ;-)

- Benjamin Hindman


On July 16, 2014, 7:45 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23563/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 7:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1608
>     https://issues.apache.org/jira/browse/MESOS-1608
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Ripped off from Tim St. Clair's branch at https://github.com/timothysc/mesos/commit/86c212197d56c4897acbe09617b696eb496e14f2
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am b562e870b05915878b4e7e771b89bee3ecc114e7 
>   3rdparty/libprocess/3rdparty/stout/configure.ac 86e1ff369bdcf1056bf2ce7606aa3c910e699173 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23563/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> make install DESTDIR=/tmp/mesos-install
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>