Author: markt
Date: Fri Mar 16 17:52:01 2018
New Revision: 1827037
URL: http://svn.apache.org/viewvc?rev=1827037&view=rev
Log:
SpotBugs
Fix some warnings
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/ThroughputInterceptor.java
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/ThroughputInterceptor.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/ThroughputInterceptor.java?rev=1827037&r1=1827036&r2=1827037&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/ThroughputInterceptor.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/ThroughputInterceptor.java Fri Mar 16 17:52:01 2018
@@ -31,13 +31,6 @@ import org.apache.catalina.tribes.util.S
import org.apache.juli.logging.Log;
import org.apache.juli.logging.LogFactory;
-
-
-/**
- *
- *
- * @version 1.0
- */
public class ThroughputInterceptor extends ChannelInterceptorBase
implements ThroughputInterceptorMBean {
@@ -75,7 +68,7 @@ public class ThroughputInterceptor exten
if ( access.addAndGet(-1) == 0 ) {
long stop = System.currentTimeMillis();
timeTx += (stop - txStart) / 1000d;
- if ((msgTxCnt.get() / interval) >= lastCnt) {
+ if ((msgTxCnt.get() / (double) interval) >= lastCnt) {
lastCnt++;
report(timeTx);
}
@@ -98,8 +91,9 @@ public class ThroughputInterceptor exten
public void report(double timeTx) {
if ( log.isInfoEnabled() )
log.info(sm.getString("throughputInterceptor.report",
- msgTxCnt, df.format(mbTx), df.format(mbAppTx), df.format(timeTx), df.format(mbTx/timeTx),
- df.format(mbAppTx/timeTx), msgTxErr, msgRxCnt, df.format(mbRx/((System.currentTimeMillis()-rxStart)/1000)),
+ msgTxCnt, df.format(mbTx), df.format(mbAppTx), df.format(timeTx),
+ df.format(mbTx/timeTx), df.format(mbAppTx/timeTx), msgTxErr, msgRxCnt,
+ df.format(mbRx/((System.currentTimeMillis()-rxStart)/(double)1000)),
df.format(mbRx)));
}
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1827037&r1=1827036&r2=1827037&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Fri Mar 16 17:52:01 2018
@@ -517,6 +517,12 @@
<Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" />
</Match>
<Match>
+ <!-- Monitor only used for election -->
+ <Class name="org.apache.catalina.tribes.group.interceptors.NonBlockingCoordinator"/>
+ <Method name="startElection"/>
+ <Bug pattern="WA_NOT_IN_LOOP"/>
+ </Match>
+ <Match>
<Class name="org.apache.catalina.tribes.group.interceptors.TcpFailureDetector"/>
<Method name="memberAlive"/>
<Bug code="DE"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org