[jira] [Resolved] (LUCENE-8148) Get precommit Lint warnings out of test code

["Erick Erickson (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erick Erickson resolved LUCENE-8148.
------------------------------------
    Fix Version/s: 8.6
       Resolution: Fixed

The 9x Gradle builds build without warnings and will now fail on any new warnings that are introduced.

Due to some third-party compile-only dependencies (LPGL licenses required) in Solr, we weren't able to make Ant builds fail, you'll see several warnings about annotations (Solr only) that may be safely ignored. Please consider using the Gradle build for 9x.

> Get precommit Lint warnings out of test code
> --------------------------------------------
>
>                 Key: LUCENE-8148
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8148
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>             Fix For: 8.6
>
>
> Mostly putting this up for discussion. I'm starting to work on Solr test lint warnings, it seems right to break the Lucene changes and Solr changes into separate JIRAs.
> First of all, do people have objections to me mucking around in the Lucene test code to do this? The eventual goal here is to get to the point where we can turn on precommit failures on lint warnings. Deprecations maybe as well, but that's a separate issue, as is non-test code.
> I expect to see a lot of pretty safe issues, then a series I'm not sure of, I'll ask when I find them if I wind up carrying this forward. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org