You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/01 12:55:24 UTC
[GitHub] [airflow] mdediana opened a new pull request #9091: [AIRFLOW-8649] [WIP] Add support for multiple Cron expressions as schedule interval
mdediana opened a new pull request #9091:
URL: https://github.com/apache/airflow/pull/9091
Currently Airflow can't execute some schedules, e.g., every 10 min between 16:30 and 18:10. This type of schedule becomes possible if defined as multiple cron expressions.
This PR is still a work in progress, meant for discussing the viability of such feature.
Some points to consider:
- The first commit shows what is possible with minimal code changes. The second commit goes further and replaces all uses of `croniter` with the new `Cron` class. Which one is preferable?
- The second commit changes `normalized_schedule_interval` in DAG, moving the translation of cron presets (e.g `@daily`) into the `Cron` class? Is it a good idea? Maybe not, as at least one serialization test broke and had to be fixed, I imagine other things may also break.
- How should this type of schedule interval be displayed on the web UI? For up to three or four elements it looks fine, but for example a schedule interval with 10 cron expressions in the list is difficult to show, starting with the `Schedule` column in the Home page.
- At the moment the class lives in `utils/dates.py`, should it be somewhere else? Maybe create a `models/scheduleinterval.py`?
- Missing documentation.
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mdediana closed pull request #9091: [WIP] [8649] Add support for multiple cron expressions as schedule interval
Posted by GitBox <gi...@apache.org>.
mdediana closed pull request #9091:
URL: https://github.com/apache/airflow/pull/9091
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9091: [WIP] [8649] Add support for multiple cron expressions as schedule interval
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9091:
URL: https://github.com/apache/airflow/pull/9091#discussion_r433226615
##########
File path: airflow/models/dag.py
##########
@@ -59,7 +58,7 @@
log = logging.getLogger(__name__)
-ScheduleInterval = Union[str, timedelta, relativedelta]
+ScheduleInterval = Union[str, list, timedelta, relativedelta]
Review comment:
```suggestion
ScheduleInterval = Union[str, List[str], timedelta, relativedelta]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mdediana commented on pull request #9091: [WIP] [8649] Add support for multiple cron expressions as schedule interval
Posted by GitBox <gi...@apache.org>.
mdediana commented on pull request #9091:
URL: https://github.com/apache/airflow/pull/9091#issuecomment-660463118
Even though I still think this is an interesting idea, I now better understand the effort and risks of this change. The second commit in this PR is probably more intrusive than advisable.
I may revisit this in the future, until then, happy to help anyone who wants to take it from here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #9091: [WIP] [8649] Add support for multiple cron expressions as schedule interval
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9091:
URL: https://github.com/apache/airflow/pull/9091#issuecomment-660434807
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org