You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2020/12/09 10:45:12 UTC

[Impala-ASF-CR] IMPALA-10385: Fix RPM repo ID capitalization for Centos 8.3

Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16844


Change subject: IMPALA-10385: Fix RPM repo ID capitalization for Centos 8.3
......................................................................

IMPALA-10385: Fix RPM repo ID capitalization for Centos 8.3

Centos 8.3 changed package repo ID capitalization from MixedCase
to all lowercase. On Centos 8 snappy-devel is installed from the
PowerTools repo, which is not enabled by default, so the install command
has to enable is temporarily using the repo ID.
The capitalization change broke bootstrap_system.sh, failing builds
on Centos 8.

The patch changes the `dnf install` call to use a glob pattern
for the PowerTools repo ID to cover the naming conventions in all
Centos 8.x releases.

Change-Id: I224beb1189ce25ae66ecd78d70757537e117805a
---
M bin/bootstrap_system.sh
M bin/impala-config.sh
2 files changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/16844/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I224beb1189ce25ae66ecd78d70757537e117805a
Gerrit-Change-Number: 16844
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-10385: Fix RPM repo ID capitalization for Centos 8.3

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16844 )

Change subject: IMPALA-10385: Fix RPM repo ID capitalization for Centos 8.3
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16844/1/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/16844/1/bin/impala-config.sh@71
PS1, Line 71: 69-7644f7fe9c
> On a related note: toolchain build #68-xxxx was a mistake: I forgot to publ
https://gerrit.cloudera.org/#/c/16843/ was merged with 68, so we can't delete it.

https://github.com/apache/impala/blob/master/bin/impala-config.sh#L71

So, now I get it, this change intentionally goes to 69-7644f7fe9c, and that is fine.



-- 
To view, visit http://gerrit.cloudera.org:8080/16844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I224beb1189ce25ae66ecd78d70757537e117805a
Gerrit-Change-Number: 16844
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Dec 2020 20:15:29 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10385: Fix RPM repo ID capitalization for Centos 8.3

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.

Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/16844 )

Change subject: IMPALA-10385: Fix RPM repo ID capitalization for Centos 8.3
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16844/1/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/16844/1/bin/impala-config.sh@71
PS1, Line 71: 69-7644f7fe9c
> When this is rebased on top of https://gerrit.cloudera.org/#/c/16843/1 , do
It's the other way round: on Centos 8.2 you just need the toolchain fix from 69-7644f7fe9c; on Centos 8.3 you need both the toolchain fix and this patch for the repo name change. Automated builds would break on either of these problems on Centos 8.3.

https://gerrit.cloudera.org/#/c/16843/1 has just been merged so I'll rebase this patch on top of it to clean this up.



-- 
To view, visit http://gerrit.cloudera.org:8080/16844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I224beb1189ce25ae66ecd78d70757537e117805a
Gerrit-Change-Number: 16844
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Dec 2020 20:06:35 +0000
Gerrit-HasComments: Yes