You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by liming01 <gi...@git.apache.org> on 2016/07/25 06:04:39 UTC
[GitHub] incubator-hawq pull request #811: GPSQL-3288: Set dummy workfile pointer to ...
GitHub user liming01 opened a pull request:
https://github.com/apache/incubator-hawq/pull/811
GPSQL-3288: Set dummy workfile pointer to NULL after calling ExecWork\u2026
\u2026File_Close()
The root cause of defect GPSQL-3288 maybe:
the parameter workfile for ExecWorkFile_Close() is freed in this function, but in the calling function outside, the pointer variable still exists, we need to set it to NULL pointer immediately. I checked all valid functions cascade calling this function, only find 2 occurrence of suspect.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liming01/incubator-hawq mli/GPSQL-3288
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/811.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #811
----
commit 5cfca5825ea8a79649076bdb32f236591380d18e
Author: Ming LI <ml...@pivotal.io>
Date: 2016-07-25T05:56:55Z
GPSQL-3288: Set dummy workfile pointer to NULL after calling ExecWorkFile_Close()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #811: HAWQ-1000: Set dummy workfile pointer to NULL aft...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on the issue:
https://github.com/apache/incubator-hawq/pull/811
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #811: GPSQL-3288: Set dummy workfile pointer to NULL af...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on the issue:
https://github.com/apache/incubator-hawq/pull/811
Thanks @zhangh43, @GodenYao,
Yes, I will open a new Apache JIRA for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #811: GPSQL-3288: Set dummy workfile pointer to NULL af...
Posted by GodenYao <gi...@git.apache.org>.
Github user GodenYao commented on the issue:
https://github.com/apache/incubator-hawq/pull/811
even this is an internal customer JIRA, we should still file Apache JIRA so the repro steps and RCA are available to public.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #811: HAWQ-1000: Set dummy workfile pointer to N...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/811
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #811: HAWQ-1000: Set dummy workfile pointer to NULL aft...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/811
Above defects are covered into the modification, LGTM.
\U0001f37a HAWQ-1000
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #811: GPSQL-3288: Set dummy workfile pointer to NULL af...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/811
Additional risks:
- https://github.com/apache/incubator-hawq/blob/master/src/backend/executor/nodeHashjoin.c#L1576
- https://github.com/apache/incubator-hawq/blob/master/src/backend/utils/sort/logtape.c#L429
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #811: GPSQL-3288: Set dummy workfile pointer to NULL af...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on the issue:
https://github.com/apache/incubator-hawq/pull/811
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---