[jira] [Commented] (HADOOP-11193) Java_org_apache_hadoop_io_nativeio_NativeIO_00024POSIX_fstat returns uninitialized mode on Windows

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167876#comment-14167876 ] 

Hadoop QA commented on HADOOP-11193:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12674302/HADOOP-11193.0.patch
  against trunk revision f4b7e99.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

        {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4903//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4903//artifact/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4903//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4903//console

This message is automatically generated.

> Java_org_apache_hadoop_io_nativeio_NativeIO_00024POSIX_fstat returns uninitialized mode on Windows
> --------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11193
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11193
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 2.5.1
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-11193.0.patch
>
>
> This was caught by TestNativeIO#testFstat test. 
> Looks like an uninitialized variable mode below in NativeIO.c#Java_org_apache_hadoop_io_nativeio_NativeIO_00024POSIX_fstat around line ~278. 
> ifdef WINDOWS
>   LPWSTR owner = NULL;
>   LPWSTR group = NULL;
>   int mode;
>   jstring jstr_owner = NULL;
> ... 
> Test Report:
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.io.nativeio.TestNativeIO
> Tests run: 18, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 2.214 sec <<< FAILURE! - in org.apache.hadoop.io.native
> io.TestNativeIO
> testFstat(org.apache.hadoop.io.nativeio.TestNativeIO)  Time elapsed: 0.514 sec  <<< FAILURE!
> java.lang.AssertionError: Stat mode field should indicate a regular file expected:<32768> but was:<53248>
>         at org.junit.Assert.fail(Assert.java:88)
>         at org.junit.Assert.failNotEquals(Assert.java:743)
>         at org.junit.Assert.assertEquals(Assert.java:118)
>         at org.junit.Assert.assertEquals(Assert.java:555)
>         at org.apache.hadoop.io.nativeio.TestNativeIO.testFstat(TestNativeIO.java:96)
> Results :
> Failed tests:
>   TestNativeIO.testFstat:96 Stat mode field should indicate a regular file expected:<32768> but was:<53248>
> Tests run: 18, Failures: 1, Errors: 0, Skipped: 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)