You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/03/15 03:28:28 UTC
[GitHub] [james-project] vttranlina opened a new pull request #918: JMAP Email/set create should use tooLarge when attempt to create an oversize mail
vttranlina opened a new pull request #918:
URL: https://github.com/apache/james-project/pull/918
resolve https://github.com/linagora/james-project/issues/4492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #918: JMAP Email/set create should use tooLarge when attempt to create an oversize mail
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #918:
URL: https://github.com/apache/james-project/pull/918#discussion_r826567685
##########
File path: server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/EmailSetCreatePerformer.scala
##########
@@ -128,6 +128,6 @@ class EmailSetCreatePerformer @Inject()(serializer: EmailSetSerializer,
.flatMap(appendCommand =>
configuration.getMaximumSendSize.toScala
.filter(limit => appendCommand.getMsgIn.size() > limit)
- .map(limit => Left(SizeExceededException(appendCommand.getMsgIn.size(), limit)))
+ .map(limit => Left(TooLargeException(appendCommand.getMsgIn.size(), limit)))
Review comment:
Why do we need `TooLargeException` ? Can't we just handle `SizeExceededException` only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #918: JMAP Email/set create should use tooLarge when attempt to create an oversize mail
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #918:
URL: https://github.com/apache/james-project/pull/918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org