You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jamie Townsend (JIRA)" <ji...@codehaus.org> on 2009/10/27 13:18:26 UTC

[jira] Created: (MDEP-237) excludeGroupId filter doesn't do exact match

excludeGroupId filter doesn't do exact match
--------------------------------------------

                 Key: MDEP-237
                 URL: http://jira.codehaus.org/browse/MDEP-237
             Project: Maven 2.x Dependency Plugin
          Issue Type: Bug
          Components: copy-dependencies
    Affects Versions: 2.1, 2.0
            Reporter: Jamie Townsend
            Assignee: Brian Fox
            Priority: Minor


We are using copy-dependencies and need to exclude our product dependencies (com.company.product:artifact), however we need to include product extensions (com.company.productx.utilities:extentionArtifact).  Specifying <excludeGroupIds>com.company.product</excludeGroupIds> should not inherently do a "startsWith", specifying <excludeGroupIds>com.company.product*</excludeGroupIds> should do a "startsWith".

Guilty code from: org.apache.maven.shared.artifact.filter.collection.GroupIdFilter.java
{code}
    protected boolean compareFeatures( String lhs, String rhs )
    {
        return lhs.startsWith( rhs );
    }
{code}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MDEP-237) excludeGroupId filter doesn't do exact match

Posted by "Jamie Townsend (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MDEP-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196222#action_196222 ] 

Jamie Townsend commented on MDEP-237:
-------------------------------------

We are able to work around this issue by specifying 2 copy-dependencies executions.  The first excludes com.company.product.  The second includes com.company.productx.

> excludeGroupId filter doesn't do exact match
> --------------------------------------------
>
>                 Key: MDEP-237
>                 URL: http://jira.codehaus.org/browse/MDEP-237
>             Project: Maven 2.x Dependency Plugin
>          Issue Type: Bug
>          Components: copy-dependencies
>    Affects Versions: 2.0, 2.1
>            Reporter: Jamie Townsend
>            Assignee: Brian Fox
>            Priority: Minor
>
> We are using copy-dependencies and need to exclude our product dependencies (com.company.product:artifact), however we need to include product extensions (com.company.productx.utilities:extentionArtifact).  Specifying <excludeGroupIds>com.company.product</excludeGroupIds> should not inherently do a "startsWith", specifying <excludeGroupIds>com.company.product*</excludeGroupIds> should do a "startsWith".
> Guilty code from: org.apache.maven.shared.artifact.filter.collection.GroupIdFilter.java
> {code}
>     protected boolean compareFeatures( String lhs, String rhs )
>     {
>         return lhs.startsWith( rhs );
>     }
> {code}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira