You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/25 20:43:38 UTC

[GitHub] [airflow] bbovenzi opened a new pull request #16073: Add close/open indicator for import dag errors

bbovenzi opened a new pull request #16073:
URL: https://github.com/apache/airflow/pull/16073

Make it clear to a user that they can open and close each import error by adding an icon to the right.

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryanahamilton commented on a change in pull request #16073: Add close/open indicator for import dag errors

Posted by GitBox <gi...@apache.org>.

ryanahamilton commented on a change in pull request #16073:
URL: https://github.com/apache/airflow/pull/16073#discussion_r639337386



##########
File path: airflow/www/static/css/flash.css
##########
@@ -48,3 +49,25 @@
 .expanded-error {
   height: 100%;
 }
+
+.dag-import-error::after {
+  /* symbol for "opening" panels */
+  font-family: FontAwesome;/* stylelint-disable-line font-family-no-missing-generic-family-keyword */
+  content: "\f078";
+  float: right;
+  color: #e43921;
+  position: absolute;
+  top: 0;
+  right: 0;
+}
+
+.dag-import-error.expanded-error::after {
+  /* symbol for "closing" panels */
+  font-family: FontAwesome;/* stylelint-disable-line font-family-no-missing-generic-family-keyword */
+  content: "\f054";
+  float: right;
+  color: #e43921;
+  position: absolute;
+  top: 0;
+  right: 0;

Review comment:
       Seems like most of this would already be inherited from `.dag-import-error`?
   ```suggestion
     content: "\f054";
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #16073: Add close/open indicator for import dag errors

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #16073:
URL: https://github.com/apache/airflow/pull/16073#issuecomment-848844395


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryanahamilton merged pull request #16073: Add close/open indicator for import dag errors

Posted by GitBox <gi...@apache.org>.

ryanahamilton merged pull request #16073:
URL: https://github.com/apache/airflow/pull/16073


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org