[GitHub] [incubator-pegasus] Smityz commented on a change in pull request #829: feat: support read throttling by size

[GitBox <gi...@apache.org>]

Smityz commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r740049970



##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -274,6 +281,12 @@ void pegasus_server_impl::on_get(get_rpc rpc)
     resp.partition_index = _gpid.get_partition_index();
     resp.server = _primary_address;
 
+    if (!_read_size_throttling_controller->get_token(FLAGS_read_throttling_by_size_request_count)) {

Review comment:
       Actually, it has nothing to do with any size, it only checks if the token basket is empty. If it's empty, then reject all requests




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org