You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2019/04/04 19:52:00 UTC

[jira] [Resolved] (ARROW-5081) [C++] Consistently use PATH_SUFFIXES in CMake config

     [ https://issues.apache.org/jira/browse/ARROW-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes McKinney resolved ARROW-5081.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 0.14.0

Issue resolved by pull request 4092
[https://github.com/apache/arrow/pull/4092]

> [C++] Consistently use PATH_SUFFIXES in CMake config
> ----------------------------------------------------
>
>                 Key: ARROW-5081
>                 URL: https://issues.apache.org/jira/browse/ARROW-5081
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: David Li
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.14.0
>
>          Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> In trying to set up a build using system libraries installed to non-default paths, CMake doesn't consistently search user-specified paths for libraries.
> For instance, FindDoubleConversion.cmake will look only at ${DoubleConversion_ROOT}/libdoubleconversion.so for the shared library, making it impossible to have a directory setup like doubleconversion/lib/*.so + doubleconversion/include. Other Find*.cmake files set PATH_SUFFIXES to also search the lib/ subdirectory; we should do this everywhere.
> Additionally, it seems the various Find*.cmake files set PATH_SUFFIXES inconsistently. Some hardcode their own list, others use CMAKE_LIBRARY_ARCHITECTURE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)