You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Remy Maucherat <re...@apache.org> on 2004/12/04 18:39:36 UTC

Annoyance in the deployer

Hi,

Not something major, but there's that in the deployer:
                // Make sure there is an application configuration directory
                // This is needed if the Context appBase is the same as the
                // web server document root to make sure only web 
applications
                // are deployed and not directories for web space.
                File webInf = new File(dir, "/WEB-INF");
                if (!webInf.exists() || !webInf.isDirectory() ||
                    !webInf.canRead())
                    continue;

Is that really useful ? I ask because it prevents dropping a folder 
containing a bunch of files in webapps (without creating a stupid 
WEB-INF folder), which could be annoying.

Rémy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: Annoyance in the deployer

Posted by Remy Maucherat <re...@apache.org>.
Bill Barker wrote:

>> Hi,
>>
>> Not something major, but there's that in the deployer:
>>                // Make sure there is an application configuration 
>> directory
>>                // This is needed if the Context appBase is the same 
>> as the
>>                // web server document root to make sure only web 
>> applications
>>                // are deployed and not directories for web space.
>>                File webInf = new File(dir, "/WEB-INF");
>>                if (!webInf.exists() || !webInf.isDirectory() ||
>>                    !webInf.canRead())
>>                    continue;
>>
>> Is that really useful ? I ask because it prevents dropping a folder 
>> containing a bunch of files in webapps (without creating a stupid 
>> WEB-INF folder), which could be annoying.
>>
> Actually, I recently had a case where someone accidentally deleted 
> WEB-INF on a development box.  When the Context didn't load, the 
> problem was noticed immediately :).

Yes, I guess it's easier to spot that particular problem :)

> Personally, I like the check (but won't veto the change).  But then, I 
> believe that dropping in a folder containing a bunch of static files 
> is what the Alias directive in Apache/httpd is for ;-).

Ok.

Maybe I can see if we could try to make recommendations for that kind of 
defaults and behaviors in the specification.

Rémy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: Annoyance in the deployer

Posted by Bill Barker <wb...@wilshire.com>.
----- Original Message ----- 
From: "Remy Maucherat" <re...@apache.org>
To: "Tomcat Developers List" <to...@jakarta.apache.org>
Sent: Saturday, December 04, 2004 9:39 AM
Subject: Annoyance in the deployer


>Hi,
>
>Not something major, but there's that in the deployer:
>                // Make sure there is an application configuration 
> directory
>                // This is needed if the Context appBase is the same as the
>                // web server document root to make sure only web 
> applications
>                // are deployed and not directories for web space.
>                File webInf = new File(dir, "/WEB-INF");
>                if (!webInf.exists() || !webInf.isDirectory() ||
>                    !webInf.canRead())
>                    continue;
>
>Is that really useful ? I ask because it prevents dropping a folder 
>containing a bunch of files in webapps (without creating a stupid WEB-INF 
>folder), which could be annoying.
>
Actually, I recently had a case where someone accidentally deleted WEB-INF 
on a development box.  When the Context didn't load, the problem was noticed 
immediately :).

Personally, I like the check (but won't veto the change).  But then, I 
believe that dropping in a folder containing a bunch of static files is what 
the Alias directive in Apache/httpd is for ;-).

>Rémy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org




This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail.