You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "tomtongue (via GitHub)" <gi...@apache.org> on 2023/09/15 08:24:38 UTC

[GitHub] [iceberg] tomtongue commented on a diff in pull request #8562: Docs: Fix CREATE BRANCH syntax and broken link in Writing to Branches section

tomtongue commented on code in PR #8562:
URL: https://github.com/apache/iceberg/pull/8562#discussion_r1326970634


##########
docs/spark-writes.md:
##########
@@ -210,7 +210,7 @@ Branch writes can also be performed as part of a write-audit-publish (WAP) workf
 Note WAP branch and branch identifier cannot both be specified.
 Also, the branch must exist before performing the write. 
 The operation does **not** create the branch if it does not exist. 
-For more information on branches please refer to [branches](../tables/branching)
+For more information on branches please refer to [branches](../branching)

Review Comment:
   @manuzhang @nastra thanks for looking at this and pointing the page to me. Just a nit, the current doc returns 404 not found when choosing **branches** in https://iceberg.apache.org/docs/1.3.1/spark-writes/#writing-to-branches section. The link shows https://iceberg.apache.org/docs/tables/branching but the correct link seems to be https://iceberg.apache.org/docs/<version>/branching. That's why I changed update the link. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org