You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/03/07 19:15:35 UTC

[GitHub] [commons-release-plugin] arturobernalg opened a new pull request #42: Complete javadoc

arturobernalg opened a new pull request #42:
URL: https://github.com/apache/commons-release-plugin/pull/42


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-release-plugin] coveralls edited a comment on pull request #42: Complete javadoc

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #42:
URL: https://github.com/apache/commons-release-plugin/pull/42#issuecomment-792336233


   
   [![Coverage Status](https://coveralls.io/builds/37727835/badge)](https://coveralls.io/builds/37727835)
   
   Coverage remained the same at 74.937% when pulling **9ba4677b42255a6c91efca764895d7e81a601aa9 on arturobernalg:feature/javadoc** into **821329ebd304a3f8414d25b49bd2ebf4b2e3bb14 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-release-plugin] arturobernalg commented on a change in pull request #42: Complete javadoc

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #42:
URL: https://github.com/apache/commons-release-plugin/pull/42#discussion_r589076861



##########
File path: src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java
##########
@@ -380,7 +380,7 @@ private File copyReleaseNotesToWorkingDirectory() throws MojoExecutionException
      * <code>${basedir}/target/commons-release-plugin/scm/signature-validator.sh</code>.
      *
      * @return the {@link File} for the signature-validator.sh
-     * @throws MojoExecutionException
+     * @throws MojoExecutionException if an error occurs during the resource is copy

Review comment:
       Hi @kinow 
   Thank you for the tip
   
   changed for --> `@throws MojoExecutionException if an error occurs during the resource is being copied`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-release-plugin] kinow commented on a change in pull request #42: Complete javadoc

Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #42:
URL: https://github.com/apache/commons-release-plugin/pull/42#discussion_r589088712



##########
File path: src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java
##########
@@ -380,7 +380,7 @@ private File copyReleaseNotesToWorkingDirectory() throws MojoExecutionException
      * <code>${basedir}/target/commons-release-plugin/scm/signature-validator.sh</code>.
      *
      * @return the {@link File} for the signature-validator.sh
-     * @throws MojoExecutionException
+     * @throws MojoExecutionException if an error occurs during the resource is copy

Review comment:
       I didn't pay attention to the rest of the text when I suggested the modification. I can edit & merge it if you'd like me to




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-release-plugin] coveralls commented on pull request #42: Complete javadoc

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #42:
URL: https://github.com/apache/commons-release-plugin/pull/42#issuecomment-792336233


   
   [![Coverage Status](https://coveralls.io/builds/37720026/badge)](https://coveralls.io/builds/37720026)
   
   Coverage remained the same at 74.937% when pulling **6a1a7fb5e723a6348b955717129a5d1af26cca0d on arturobernalg:feature/javadoc** into **821329ebd304a3f8414d25b49bd2ebf4b2e3bb14 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-release-plugin] kinow commented on a change in pull request #42: Complete javadoc

Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #42:
URL: https://github.com/apache/commons-release-plugin/pull/42#discussion_r589088634



##########
File path: src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java
##########
@@ -380,7 +380,7 @@ private File copyReleaseNotesToWorkingDirectory() throws MojoExecutionException
      * <code>${basedir}/target/commons-release-plugin/scm/signature-validator.sh</code>.
      *
      * @return the {@link File} for the signature-validator.sh
-     * @throws MojoExecutionException
+     * @throws MojoExecutionException if an error occurs during the resource is copy

Review comment:
       Sorry, my mistake @arturobernalg . It now should be "if an error occurs when the resource is being copied". I think "when" or "while" fit in here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-release-plugin] coveralls edited a comment on pull request #42: Complete javadoc

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #42:
URL: https://github.com/apache/commons-release-plugin/pull/42#issuecomment-792336233


   
   [![Coverage Status](https://coveralls.io/builds/37727840/badge)](https://coveralls.io/builds/37727840)
   
   Coverage remained the same at 74.937% when pulling **9ba4677b42255a6c91efca764895d7e81a601aa9 on arturobernalg:feature/javadoc** into **821329ebd304a3f8414d25b49bd2ebf4b2e3bb14 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-release-plugin] kinow commented on a change in pull request #42: Complete javadoc

Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #42:
URL: https://github.com/apache/commons-release-plugin/pull/42#discussion_r589075171



##########
File path: src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java
##########
@@ -380,7 +380,7 @@ private File copyReleaseNotesToWorkingDirectory() throws MojoExecutionException
      * <code>${basedir}/target/commons-release-plugin/scm/signature-validator.sh</code>.
      *
      * @return the {@link File} for the signature-validator.sh
-     * @throws MojoExecutionException
+     * @throws MojoExecutionException if an error occurs during the resource is copy

Review comment:
       I think it could be "is copied", or "is being copied"… though not a native speaker, so safer is someone else takes a look perhaps.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-release-plugin] coveralls edited a comment on pull request #42: Complete javadoc

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #42:
URL: https://github.com/apache/commons-release-plugin/pull/42#issuecomment-792336233


   
   [![Coverage Status](https://coveralls.io/builds/37720282/badge)](https://coveralls.io/builds/37720282)
   
   Coverage remained the same at 74.937% when pulling **31575651c8fed9b4e05f585747f096c09ac33b69 on arturobernalg:feature/javadoc** into **821329ebd304a3f8414d25b49bd2ebf4b2e3bb14 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-release-plugin] arturobernalg commented on a change in pull request #42: Complete javadoc

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #42:
URL: https://github.com/apache/commons-release-plugin/pull/42#discussion_r589177158



##########
File path: src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java
##########
@@ -380,7 +380,7 @@ private File copyReleaseNotesToWorkingDirectory() throws MojoExecutionException
      * <code>${basedir}/target/commons-release-plugin/scm/signature-validator.sh</code>.
      *
      * @return the {@link File} for the signature-validator.sh
-     * @throws MojoExecutionException
+     * @throws MojoExecutionException if an error occurs during the resource is copy

Review comment:
       Hi @kinow 
   Don't worry.  Change.
   Ty




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-release-plugin] coveralls edited a comment on pull request #42: Complete javadoc

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #42:
URL: https://github.com/apache/commons-release-plugin/pull/42#issuecomment-792336233


   
   [![Coverage Status](https://coveralls.io/builds/37720273/badge)](https://coveralls.io/builds/37720273)
   
   Coverage remained the same at 74.937% when pulling **31575651c8fed9b4e05f585747f096c09ac33b69 on arturobernalg:feature/javadoc** into **821329ebd304a3f8414d25b49bd2ebf4b2e3bb14 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-release-plugin] kinow merged pull request #42: Complete javadoc

Posted by GitBox <gi...@apache.org>.
kinow merged pull request #42:
URL: https://github.com/apache/commons-release-plugin/pull/42


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org