You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/30 16:46:21 UTC
[jira] [Commented] (METRON-399) Stellar Date Functions Should
Default to Current Time
[ https://issues.apache.org/jira/browse/METRON-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449495#comment-15449495 ]
ASF GitHub Bot commented on METRON-399:
---------------------------------------
GitHub user nickwallen opened a pull request:
https://github.com/apache/incubator-metron/pull/237
METRON-399 Stellar Date Functions Should Default to Current Time
### [METRON-399](https://issues.apache.org/jira/browse/METRON-399)
The Stellar date functions expect an argument of a Long containing the epoch time in milliseconds. If no argument is supplied, a parse exception is thrown.
```
WEEK_OF_YEAR(timestamp)
```
This should be changed so that if no argument is supplied, the function assumes the current time.
```
WEEK_OF_YEAR()
```
If an argument is passed that is not valid, the function should continue to return null.
This updates the functioning of all date functions included in #231 .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/incubator-metron METRON-399
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/237.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #237
----
commit 388b11d2907f47dd66cecc73621309db772360b7
Author: Nick Allen <ni...@nickallen.org>
Date: 2016-08-30T16:42:04Z
METRON-399 Stellar Date Functions Should Default to Current Time
----
> Stellar Date Functions Should Default to Current Time
> -----------------------------------------------------
>
> Key: METRON-399
> URL: https://issues.apache.org/jira/browse/METRON-399
> Project: Metron
> Issue Type: Improvement
> Reporter: Nick Allen
> Assignee: Nick Allen
> Labels: stellar
>
> The Stellar date functions expect an argument of a Long containing the epoch time in milliseconds. If no argument is supplied, a parse exception is thrown.
> {code}
> WEEK_OF_YEAR(timestamp)
> {code}
> This should be changed so that if no argument is supplied, the function assumes the current time.
> {code}
> WEEK_OF_YEAR()
> {code}
> If an argument is passed that is not valid, the function should continue to return null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)