You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "phofl (via GitHub)" <gi...@apache.org> on 2023/03/16 18:48:00 UTC

[GitHub] [arrow] phofl opened a new pull request, #34593: MINOR: [Python] Set copy=False explicitly when creating a pandas Series

phofl opened a new pull request, #34593:
URL: https://github.com/apache/arrow/pull/34593

   <!--
   Thanks for opening a pull request!
   If this is your first pull request you can find detailed information on how 
   to contribute here:
     * [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
     * [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
   
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   In the case of PARQUET issues on JIRA the title also supports:
   
       PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   -->
   
   ### Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   pandas will change the default for creating a Series from an array (numpy, arrow, ...) to copy=True when Copy-on-Write is enabled. To avoid this when using it internally, we have to specify copy=False explicitly.
   
   ### What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Setting copy=False when creating a Series
   
   ### Are these changes tested?
   
   This is equivalent to the current default behavior, so no reason to add any additional tests. 
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ### Are there any user-facing changes?
   
   no
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
   -->
   <!-- **This PR includes breaking changes to public APIs.** -->
   
   <!--
   Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
   -->
   <!-- **This PR contains a "Critical Fix".** -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #34593: GH-34703: [Python] Set copy=False explicitly when creating a pandas Series

Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34593:
URL: https://github.com/apache/arrow/pull/34593#issuecomment-1481795025

   Benchmark runs are scheduled for baseline = caa78981259fc029182e677f13183371822ce410 and contender = 1140a53f51a35c37008d97d43b2d00cff4ae2caa. 1140a53f51a35c37008d97d43b2d00cff4ae2caa is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c966924382c5430e95e2ba0072d763cf...7aa486ca0e29400988b4369834b9a88f/)
   [Failed :arrow_down:0.27% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/df8e8eae65cb449fa01ed8cd879e79b7...119c2b2db73f4f01876e1feda0789cad/)
   [Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/87e12d076f6c4ffa8db48719c4f8537a...7508ee19ae4347f8a80270d6d9910bf0/)
   [Finished :arrow_down:0.19% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/38fd34cd5e584958b71c69e18e3a1234...b7ba2a4ce62f4c2d905d7d7a210731ff/)
   Buildkite builds:
   [Finished] [`1140a53f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2563)
   [Failed] [`1140a53f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2593)
   [Finished] [`1140a53f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2561)
   [Finished] [`1140a53f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2584)
   [Finished] [`caa78981` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2562)
   [Failed] [`caa78981` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2592)
   [Finished] [`caa78981` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2560)
   [Finished] [`caa78981` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2583)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] phofl commented on pull request #34593: MINOR: [Python] Set copy=False explicitly when creating a pandas Series

Posted by "phofl (via GitHub)" <gi...@apache.org>.
phofl commented on PR #34593:
URL: https://github.com/apache/arrow/pull/34593#issuecomment-1478439298

   This doesn’t change anything right now, since copy=False is still the default in pandas for quite some time. Not setting this explicitly makes testing in pandas tricky though.
   
   can open an issue if you prefer, but there isn’t really any change at all right now and since you are using series only with arrays internally there won’t be a user facing change at all (if I am not mistaken)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] AlenkaF commented on pull request #34593: MINOR: [Python] Set copy=False explicitly when creating a pandas Series

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #34593:
URL: https://github.com/apache/arrow/pull/34593#issuecomment-1477585231

   Could you open an issue for this PR as it is not a minor change even though the diff is small ;) https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #34593: GH-34703: [Python] Set copy=False explicitly when creating a pandas Series

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34593:
URL: https://github.com/apache/arrow/pull/34593#issuecomment-1480972797

   :warning: GitHub issue #34703 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] AlenkaF commented on pull request #34593: GH-34703: [Python] Set copy=False explicitly when creating a pandas Series

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #34593:
URL: https://github.com/apache/arrow/pull/34593#issuecomment-1480994051

   > This doesn’t change anything right now, since copy=False is still the default in pandas for quite some time. Not setting this explicitly makes testing in pandas tricky though.
   > 
   > can open an issue if you prefer, but there isn’t really any change at all right now and since you are using series only with arrays internally there won’t be a user facing change at all (if I am not mistaken)
   
   Agree and totally understand. The issue creation has more to do with the workflow we currently have (only docs changes can be minor PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #34593: GH-34703: [Python] Set copy=False explicitly when creating a pandas Series

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34593:
URL: https://github.com/apache/arrow/pull/34593#issuecomment-1480972737

   * Closes: #34703


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] AlenkaF merged pull request #34593: GH-34703: [Python] Set copy=False explicitly when creating a pandas Series

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF merged PR #34593:
URL: https://github.com/apache/arrow/pull/34593


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org