You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "lewiszlw (via GitHub)" <gi...@apache.org> on 2024/12/27 16:58:18 UTC
[PR] Add orbstack guide [iceberg-rust]
lewiszlw opened a new pull request, #856:
URL: https://github.com/apache/iceberg-rust/pull/856
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add orbstack guide [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #856:
URL: https://github.com/apache/iceberg-rust/pull/856#discussion_r1901251672
##########
docs/contributing/orbstack.md:
##########
@@ -0,0 +1,39 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+-->
+
+# OrbStack as a docker alternative on macOS
+1. Install OrbStack by downloading [installer](https://orbstack.dev/download) or using Homebrew.
+ ```shell
+ brew install orbstack
+ ```
+
+2. Migrate Docker data
+ ```shell
+ orbstack migrate docker
+ ```
+
+3. (Optional) Add registry mirrors
+
+ You can edit the config directly at `~/.orbstack/config/docker.json` and restart the engine with `orb restart docker`.
+
+ ```
+ {
+ "registry-mirrors": ["https://registry.docker.ir", "https://docker.iranserver.com"]
Review Comment:
https://github.com/apache/iceberg-rust/pull/866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add orbstack guide [iceberg-rust]
Posted by "lewiszlw (via GitHub)" <gi...@apache.org>.
lewiszlw commented on code in PR #856:
URL: https://github.com/apache/iceberg-rust/pull/856#discussion_r1899234586
##########
CONTRIBUTING.md:
##########
@@ -116,7 +116,7 @@ cargo 1.69.0 (6e9a83356 2023-04-12)
Currently, iceberg-rust uses Docker to set up environment for integration tests. Native Docker has some limitations, please check (https://github.com/apache/iceberg-rust/pull/748). Please use Orbstack or Podman.
-For MacOS users, you can install [OrbStack](https://orbstack.dev/) as a docker alternative.
+For MacOS users, you can install [OrbStack as a docker alternative](docs/contributing/orbstack.md).
Review Comment:
We have podman guide in repo. I think adding orbstack guide is helpful to new contributer as it's not trival to run tests like other rust projects, we should lower the threshold for new contributers as much as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add orbstack guide [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 merged PR #856:
URL: https://github.com/apache/iceberg-rust/pull/856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add orbstack guide [iceberg-rust]
Posted by "lewiszlw (via GitHub)" <gi...@apache.org>.
lewiszlw commented on code in PR #856:
URL: https://github.com/apache/iceberg-rust/pull/856#discussion_r1899296910
##########
docs/contributing/orbstack.md:
##########
@@ -0,0 +1,39 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+-->
+
+# OrbStack as a docker alternative on macOS
+1. Install OrbStack by downloading [installer](https://orbstack.dev/download) or using Homebrew.
+ ```shell
+ brew install orbstack
+ ```
+
+2. Migrate Docker data
+ ```shell
+ orbstack migrate docker
+ ```
+
+3. (Optional) Add registry mirrors
+
+ You can edit the config directly at `~/.orbstack/config/docker.json` and restart the engine with `orb restart docker`.
+
+ ```
+ {
+ "registry-mirrors": ["https://registry.docker.ir", "https://docker.iranserver.com"]
Review Comment:
These registry mirrors are just example, copied from https://github.com/orbstack/orbstack/issues/51#issuecomment-2390824878 . I think we can change it like
```
{
"registry-mirrors": ["<mirror_addr>"]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add orbstack guide [iceberg-rust]
Posted by "xxchan (via GitHub)" <gi...@apache.org>.
xxchan commented on code in PR #856:
URL: https://github.com/apache/iceberg-rust/pull/856#discussion_r1898788972
##########
CONTRIBUTING.md:
##########
@@ -116,7 +116,7 @@ cargo 1.69.0 (6e9a83356 2023-04-12)
Currently, iceberg-rust uses Docker to set up environment for integration tests. Native Docker has some limitations, please check (https://github.com/apache/iceberg-rust/pull/748). Please use Orbstack or Podman.
-For MacOS users, you can install [OrbStack](https://orbstack.dev/) as a docker alternative.
+For MacOS users, you can install [OrbStack as a docker alternative](docs/contributing/orbstack.md).
Review Comment:
Adding guide about how to use a tool seems strange to me, unless we need project-specific settings. It should be enough to link to the tool's doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add orbstack guide [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #856:
URL: https://github.com/apache/iceberg-rust/pull/856#discussion_r1899887407
##########
docs/contributing/orbstack.md:
##########
@@ -0,0 +1,39 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+-->
+
+# OrbStack as a docker alternative on macOS
+1. Install OrbStack by downloading [installer](https://orbstack.dev/download) or using Homebrew.
+ ```shell
+ brew install orbstack
+ ```
+
+2. Migrate Docker data
+ ```shell
+ orbstack migrate docker
+ ```
+
+3. (Optional) Add registry mirrors
+
+ You can edit the config directly at `~/.orbstack/config/docker.json` and restart the engine with `orb restart docker`.
+
+ ```
+ {
+ "registry-mirrors": ["https://registry.docker.ir", "https://docker.iranserver.com"]
Review Comment:
that sounds good to me, thanks!
Let's see if I can change it right here from github:
```suggestion
"registry-mirrors": ["<mirror_addr>"]
```
edit: guess not since its already merged. Would you like to make the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add orbstack guide [iceberg-rust]
Posted by "xxchan (via GitHub)" <gi...@apache.org>.
xxchan commented on code in PR #856:
URL: https://github.com/apache/iceberg-rust/pull/856#discussion_r1898788972
##########
CONTRIBUTING.md:
##########
@@ -116,7 +116,7 @@ cargo 1.69.0 (6e9a83356 2023-04-12)
Currently, iceberg-rust uses Docker to set up environment for integration tests. Native Docker has some limitations, please check (https://github.com/apache/iceberg-rust/pull/748). Please use Orbstack or Podman.
-For MacOS users, you can install [OrbStack](https://orbstack.dev/) as a docker alternative.
+For MacOS users, you can install [OrbStack as a docker alternative](docs/contributing/orbstack.md).
Review Comment:
Adding guide about how to use a tool seems strange to me. It should be enough to link to the tool's doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add orbstack guide [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #856:
URL: https://github.com/apache/iceberg-rust/pull/856#discussion_r1899255390
##########
docs/contributing/orbstack.md:
##########
@@ -0,0 +1,39 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+-->
+
+# OrbStack as a docker alternative on macOS
+1. Install OrbStack by downloading [installer](https://orbstack.dev/download) or using Homebrew.
+ ```shell
+ brew install orbstack
+ ```
+
+2. Migrate Docker data
+ ```shell
+ orbstack migrate docker
+ ```
+
+3. (Optional) Add registry mirrors
+
+ You can edit the config directly at `~/.orbstack/config/docker.json` and restart the engine with `orb restart docker`.
+
+ ```
+ {
+ "registry-mirrors": ["https://registry.docker.ir", "https://docker.iranserver.com"]
Review Comment:
nit: why are these registry mirrors part of the PR? The only reference i can find about these registry mirrors is here https://github.com/orbstack/orbstack/issues/51#issuecomment-2390824878
It doesnt seem like these mirrors are commonly used
* https://grep.app/search?q=docker.iranserver.com
* https://grep.app/search?q=registry.docker.ir
can we remove this recommendation or change it to a more commonly used mirror?
cc @liurenjie1024 @lewiszlw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add orbstack guide [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #856:
URL: https://github.com/apache/iceberg-rust/pull/856#discussion_r1899887407
##########
docs/contributing/orbstack.md:
##########
@@ -0,0 +1,39 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+-->
+
+# OrbStack as a docker alternative on macOS
+1. Install OrbStack by downloading [installer](https://orbstack.dev/download) or using Homebrew.
+ ```shell
+ brew install orbstack
+ ```
+
+2. Migrate Docker data
+ ```shell
+ orbstack migrate docker
+ ```
+
+3. (Optional) Add registry mirrors
+
+ You can edit the config directly at `~/.orbstack/config/docker.json` and restart the engine with `orb restart docker`.
+
+ ```
+ {
+ "registry-mirrors": ["https://registry.docker.ir", "https://docker.iranserver.com"]
Review Comment:
that sounds good to me, thanks!
Let's see if I can change it right here from github:
```suggestion
"registry-mirrors": ["<mirror_addr>"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org