You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/12 15:18:43 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #3811: Improve simplification by running it twice
alamb opened a new pull request, #3811:
URL: https://github.com/apache/arrow-datafusion/pull/3811
Draft as it builds on https://github.com/apache/arrow-datafusion/pull/3741
# Which issue does this PR close?
re https://github.com/apache/arrow-datafusion/issues/3740
re https://github.com/apache/arrow-datafusion/issues/1160
# Rationale for this change
There are some fairly simple expressions that should be simplified but yet are not because additional simplifications are unlocked by the constant propagator.
For example
```
(i * 0) > 5
```
is only simplified to
```
0 > 5
```
Because the flow is
* constant evaluator runs on` (i * 0) > 5` which can not do anything,
* simplfy runs on ` (i * 0) > 5` and rewrites to `0 > 5`
Now, if the constant evaluator can run again it will result in `false` which is great. However, it is not run again and thus there is the issue.
I hit the same basic embarrassment while making the example in re https://github.com/apache/arrow-datafusion/issues/1160
The challenges with a fully general solution to this issue are described https://github.com/apache/arrow-datafusion/issues/1160. However, we have had good luck in IOx simply running the simplification / constant prop twice
# What changes are included in this PR?
1. run evaluator / constant prop twice
2. Add some more tests
# Are there any user-facing changes?
Better constant propagation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3811: Improve expression simplification by running it twice
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3811:
URL: https://github.com/apache/arrow-datafusion/pull/3811#issuecomment-1276693339
Benchmark runs are scheduled for baseline = 7179c54a11ad42d975c1a870ec2a5688fab98f13 and contender = 37fe938261636bb7710b26cf26e2bbd010e1dbf0. 37fe938261636bb7710b26cf26e2bbd010e1dbf0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6093e9aa94924fef9536ad9b0ed2ccf0...771d3e27bfb749268f1ca404ac8381ef/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/32d9f50835bc495c90ff070f855bc854...4d8b58f8432547f2ac9fe4008dc97baa/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/48b33617c1464a179a28e0e7a6e990aa...7ae284c19742484a9a026ba1e92a28b5/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6e24e6fa24f641eabb79069c9805c524...1a8613467c4c4295865eead62a080b16/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #3811: Improve expression simplification by running it twice
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #3811:
URL: https://github.com/apache/arrow-datafusion/pull/3811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org