NioSocketAcceptor/NioDatagramAcceptor inheritence scheme

[Emmanuel Lecharny <el...@apache.org>]

Hi,

while reviewing MINA 2.0 code base, I drawn the full IoService 
inheritence scheme. At some point, we have for NioSocketAcceptor this 
graph :

NioSocketAcceptor --> AbstractPollingIoAcceptor --> AbstractIoAcceptor 
--> AbstractIoService

We have almost the same inheritence schem for NioDatagramAcceptor :

NioDatagramAcceptor --> AbstractPollingConnectionlessIoAcceptor --> 
AbstractIoAcceptor --> AbstractIoService

and for VmPipeAcceptor :

VmPipeAcceptor --> AbstractIoAcceptor --> AbstractIoService

What about simplifying these scheme to gather the NioSocketAcceptor + 
AbstractPollingIoAcceptor into the NioSocketAcceptor class, and the very 
same for NioDatagramAcceptor ?

The AbstractPollingIoAcceptor class has been introduced in rev 596653, 
last november, and the AbstractPolling[Connectionless]IoAcceptor class 
has been introduced in rev 596909, without any previous discussion.

I'm sure there were some reasons why they have been added, and as there 
are no documentation on those class' header, and as mina 1.1 inheritence 
scheme is almost following similar, is there any reason to keep this 
complicated scheme ?

wdyt ?

Thanks !


-- 
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org