You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/07 04:00:00 UTC

[GitHub] [flink] PatrickRen commented on a diff in pull request #19827: [FLINK-27806][table] Support binary & varbinary types in datagen connector

PatrickRen commented on code in PR #19827:
URL: https://github.com/apache/flink/pull/19827#discussion_r890743854


##########
flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java:
##########
@@ -176,6 +195,7 @@ void testSource() throws Exception {
             assertThat(row.getLong(1)).isBetween(10L, 100L);
             assertThat(row.getLong(2)).isEqualTo(i + 50);
             assertThat(row.getTimestamp(3, 3).getMillisecond()).isBetween(begin - 5000, end);
+            assertThat(row.getBinary(4).length).isEqualTo(2);

Review Comment:
   Could we also have an assertion here for field `f5`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org