You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/20 00:50:43 UTC

[GitHub] ZhennanQin commented on a change in pull request #13297: [MKLDNN]Add quantized concat

ZhennanQin commented on a change in pull request #13297: [MKLDNN]Add quantized concat
URL: https://github.com/apache/incubator-mxnet/pull/13297#discussion_r234835955
 
 

 ##########
 File path: src/operator/quantization/quantization_utils.h
 ##########
 @@ -31,6 +31,8 @@
 namespace mxnet {
 namespace op {
 
+static const size_t uint8_range = 255;
 
 Review comment:
   Usually we use all capital for macro defined constant, not for static constant. If MXNet prefer that, I can make the change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services