You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/01/10 04:17:45 UTC

Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.


Bugs: AMBARI-9081
    https://issues.apache.org/jira/browse/AMBARI-9081


Repository: ambari


Description
-------

See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 570b124 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 6b88acb 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py b447003 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f49 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6d68f3e 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py 890c329 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py 55f191e 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd379 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 

Diff: https://reviews.apache.org/r/29790/diff/


Testing
-------

Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
Unit test results are in-progress.


Thanks,

Alejandro Fernandez


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review67587
-----------------------------------------------------------



ambari-common/src/main/python/resource_management/libraries/script/script.py
<https://reviews.apache.org/r/29790/#comment111635>

    There's no change here, so how will a client announce it's version when doing RU?  The review overall looks like client .py scripts are doing the work on configure() when it should do the same thing you have for servers on start(), but maybe on install()



ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
<https://reviews.apache.org/r/29790/#comment111632>

    Client scripts should not do this.  You should use the same type of change you made for daemon start() methods, but for maybe install() not configure()?



ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
<https://reviews.apache.org/r/29790/#comment111633>

    Client scripts should not do this.  You should use the same type of change you made for daemon start() methods, but for maybe install() not configure()?



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
<https://reviews.apache.org/r/29790/#comment111634>

    Why would this be added here for config?


- Nate Cole


On Jan. 9, 2015, 10:17 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 10:17 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 570b124 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 6b88acb 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py b447003 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f49 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6d68f3e 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py 890c329 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py 55f191e 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd379 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> Unit test results are in-progress.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review67578
-----------------------------------------------------------



ambari-common/src/main/python/resource_management/libraries/script/script.py
<https://reviews.apache.org/r/29790/#comment111614>

    All "start" functions will advertise the version.



ambari-common/src/main/python/resource_management/libraries/script/script.py
<https://reviews.apache.org/r/29790/#comment111615>

    All restarts (masters and clients) will advertise the version.
    
    In addition, all clients also advertise it on install() and configure().


- Alejandro Fernandez


On Jan. 10, 2015, 3:17 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2015, 3:17 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 570b124 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 6b88acb 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py b447003 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f49 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6d68f3e 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py 890c329 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py 55f191e 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd379 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> Unit test results are in-progress.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review67984
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Jan. 13, 2015, 7:07 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 7:07 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
>   ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
>   ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f49 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py 71ac3df 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 60f589a 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> 
> ```
> ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
>  task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
> ---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
>      104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
>      109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
>      110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
>      121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
>      122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
>      123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
>      124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
> (21 rows)
> ```
> 
> mvn clean test
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:31.481s
> [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
> [INFO] Final Memory: 66M/721M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review68146
-----------------------------------------------------------

Ship it!


I think there are issues with hdp-select hadoop-client running on machines where other components/clients have not actually been updated yet. However, I don't see a way around this exception to just do all of the work at the end in the clients grouping. That Jira has already been filed.

- Jonathan Hurley


On Jan. 14, 2015, 4:45 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 4:45 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
>   ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
>   ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 33b68c7 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> 
> ```
> ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
>  task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
> ---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
>      104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
>      109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
>      110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
>      121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
>      122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
>      123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
>      124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
> (21 rows)
> ```
> 
> mvn clean test
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:31.481s
> [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
> [INFO] Final Memory: 66M/721M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review68129
-----------------------------------------------------------

Ship it!


- Nate Cole


On Jan. 14, 2015, 4:45 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 4:45 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
>   ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
>   ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 33b68c7 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> 
> ```
> ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
>  task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
> ---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
>      104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
>      109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
>      110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
>      121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
>      122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
>      123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
>      124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
> (21 rows)
> ```
> 
> mvn clean test
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:31.481s
> [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
> [INFO] Final Memory: 66M/721M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review68154
-----------------------------------------------------------

Ship it!


Ship It!

- Yurii Shylov


On Янв. 14, 2015, 10:39 п.п., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Янв. 14, 2015, 10:39 п.п.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
>   ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py d3bcd31 
>   ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
>   ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 33b68c7 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> 
> ```
> ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
>  task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
> ---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
>      104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
>      109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
>      110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
>      121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
>      122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
>      123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
>      124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
> (21 rows)
> ```
> 
> mvn clean test
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:31.481s
> [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
> [INFO] Final Memory: 66M/721M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/
-----------------------------------------------------------

(Updated Jan. 14, 2015, 10:39 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yurii Shylov.


Changes
-------

Addressed Jonathan's comment about the case comparison of the commands.


Bugs: AMBARI-9081
    https://issues.apache.org/jira/browse/AMBARI-9081


Repository: ambari


Description
-------

See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
  ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py d3bcd31 
  ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
  ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
  ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 33b68c7 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 

Diff: https://reviews.apache.org/r/29790/diff/


Testing
-------

Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.

```
ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
 task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
     104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
     109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
     110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
     121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
     122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
     123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
     124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
(21 rows)
```

mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:31.481s
[INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
[INFO] Final Memory: 66M/721M
[INFO] ------------------------------------------------------------------------


Thanks,

Alejandro Fernandez


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Alejandro Fernandez <af...@hortonworks.com>.

> On Jan. 14, 2015, 10:10 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py, line 187
> > <https://reviews.apache.org/r/29790/diff/6/?file=821664#file821664line187>
> >
> >     do we need to worry about command_name.lower() here?

I'll make this change.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review68131
-----------------------------------------------------------


On Jan. 14, 2015, 9:45 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 9:45 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
>   ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
>   ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 33b68c7 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> 
> ```
> ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
>  task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
> ---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
>      104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
>      109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
>      110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
>      121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
>      122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
>      123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
>      124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
> (21 rows)
> ```
> 
> mvn clean test
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:31.481s
> [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
> [INFO] Final Memory: 66M/721M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Alejandro Fernandez <af...@hortonworks.com>.

> On Jan. 14, 2015, 10:10 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py, line 31
> > <https://reviews.apache.org/r/29790/diff/6/?file=821672#file821672line31>
> >
> >     hadoop-client updates yarn/mapr/hive/pig/tez as well. I think we'd want to break this out to:
> >     
> >     hdp-select hadoop-hdfs-client
> >     hdp-select hadoop-hdfs

hdp-select has no "hadoop-hdfs-client" component because HDFS Client is meant to be done with the Client group that will all use "hadoop-client"


> On Jan. 14, 2015, 10:10 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py, lines 27-29
> > <https://reviews.apache.org/r/29790/diff/6/?file=821676#file821676line27>
> >
> >     Same issue as above with hdfs; this should probably not be hadoop-client.
> >     
> >     There is another Jira that changes the "Clients" group to execute "hdp-select set clients" at the end of the upgrade.

WebHCat is done as part of the clients Group. so it must also use hdp-select set hadoop-client


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review68131
-----------------------------------------------------------


On Jan. 14, 2015, 9:45 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 9:45 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
>   ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
>   ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 33b68c7 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> 
> ```
> ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
>  task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
> ---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
>      104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
>      109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
>      110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
>      121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
>      122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
>      123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
>      124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
> (21 rows)
> ```
> 
> mvn clean test
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:31.481s
> [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
> [INFO] Final Memory: 66M/721M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Jonathan Hurley <jh...@hortonworks.com>.

> On Jan. 14, 2015, 5:10 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py, line 31
> > <https://reviews.apache.org/r/29790/diff/6/?file=821672#file821672line31>
> >
> >     hadoop-client updates yarn/mapr/hive/pig/tez as well. I think we'd want to break this out to:
> >     
> >     hdp-select hadoop-hdfs-client
> >     hdp-select hadoop-hdfs
> 
> Alejandro Fernandez wrote:
>     hdp-select has no "hadoop-hdfs-client" component because HDFS Client is meant to be done with the Client group that will all use "hadoop-client"

But since the hadoop-client command also upgrades other clients, isn't that a problem? We're upgrading all of those other clients before their actual upgrade has run.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review68131
-----------------------------------------------------------


On Jan. 14, 2015, 4:45 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 4:45 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
>   ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
>   ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 33b68c7 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> 
> ```
> ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
>  task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
> ---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
>      104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
>      109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
>      110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
>      121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
>      122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
>      123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
>      124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
> (21 rows)
> ```
> 
> mvn clean test
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:31.481s
> [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
> [INFO] Final Memory: 66M/721M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review68131
-----------------------------------------------------------



ambari-common/src/main/python/resource_management/libraries/script/script.py
<https://reviews.apache.org/r/29790/#comment112288>

    do we need to worry about command_name.lower() here?



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
<https://reviews.apache.org/r/29790/#comment112290>

    hadoop-client updates yarn/mapr/hive/pig/tez as well. I think we'd want to break this out to:
    
    hdp-select hadoop-hdfs-client
    hdp-select hadoop-hdfs



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
<https://reviews.apache.org/r/29790/#comment112292>

    Same issue as above with hdfs; this should probably not be hadoop-client.
    
    There is another Jira that changes the "Clients" group to execute "hdp-select set clients" at the end of the upgrade.


- Jonathan Hurley


On Jan. 14, 2015, 4:45 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 4:45 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
>   ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
>   ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 33b68c7 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> 
> ```
> ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
>  task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
> ---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
>      104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
>      109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
>      110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
>      121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
>      122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
>      123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
>      124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
> (21 rows)
> ```
> 
> mvn clean test
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:31.481s
> [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
> [INFO] Final Memory: 66M/721M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Alejandro Fernandez <af...@hortonworks.com>.

> On Jan. 14, 2015, 9:58 p.m., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py, line 152
> > <https://reviews.apache.org/r/29790/diff/6/?file=821664#file821664line152>
> >
> >     Instance method is changing a class variable, not an instance variable.  It would be nice to stay consistent. (Either we always change instance, or always change class)

My previous patch tried to make everything instance variables, but unit tests broke as a result, so I'm minimizing the code change so I can get this in asap. I definitely agree it should be consistent, perhaps in the near future.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review68127
-----------------------------------------------------------


On Jan. 14, 2015, 9:45 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 9:45 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
>   ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
>   ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 33b68c7 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> 
> ```
> ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
>  task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
> ---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
>      104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
>      109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
>      110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
>      121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
>      122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
>      123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
>      124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
> (21 rows)
> ```
> 
> mvn clean test
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:31.481s
> [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
> [INFO] Final Memory: 66M/721M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Nate Cole <nc...@hortonworks.com>.

> On Jan. 14, 2015, 4:58 p.m., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py, line 152
> > <https://reviews.apache.org/r/29790/diff/6/?file=821664#file821664line152>
> >
> >     Instance method is changing a class variable, not an instance variable.  It would be nice to stay consistent. (Either we always change instance, or always change class)
> 
> Alejandro Fernandez wrote:
>     My previous patch tried to make everything instance variables, but unit tests broke as a result, so I'm minimizing the code change so I can get this in asap. I definitely agree it should be consistent, perhaps in the near future.

Sounds good!


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review68127
-----------------------------------------------------------


On Jan. 14, 2015, 4:45 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 4:45 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
>   ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
>   ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 33b68c7 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> 
> ```
> ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
>  task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
> ---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
>      104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
>      109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
>      110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
>      121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
>      122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
>      123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
>      124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
> (21 rows)
> ```
> 
> mvn clean test
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:31.481s
> [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
> [INFO] Final Memory: 66M/721M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review68127
-----------------------------------------------------------



ambari-common/src/main/python/resource_management/libraries/script/script.py
<https://reviews.apache.org/r/29790/#comment112285>

    This looks like a class variable, not an instance variable.  It may not matter since we're making new instances all the time anyway?



ambari-common/src/main/python/resource_management/libraries/script/script.py
<https://reviews.apache.org/r/29790/#comment112286>

    Instance method is changing a class variable, not an instance variable.  It would be nice to stay consistent. (Either we always change instance, or always change class)


- Nate Cole


On Jan. 14, 2015, 4:45 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 4:45 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
>   ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
>   ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 33b68c7 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> 
> ```
> ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
>  task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
> ---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
>      104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
>      109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
>      110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
>      116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
>      120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
>      121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
>      122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
>      123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
>      124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
> (21 rows)
> ```
> 
> mvn clean test
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:31.481s
> [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
> [INFO] Final Memory: 66M/721M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/
-----------------------------------------------------------

(Updated Jan. 14, 2015, 9:45 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yurii Shylov.


Changes
-------

Last time's a charm, re-ran all unit tests again


Bugs: AMBARI-9081
    https://issues.apache.org/jira/browse/AMBARI-9081


Repository: ambari


Description
-------

See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
  ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
  ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
  ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 33b68c7 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 

Diff: https://reviews.apache.org/r/29790/diff/


Testing
-------

Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.

```
ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
 task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
     104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
     109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
     110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
     121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
     122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
     123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
     124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
(21 rows)
```

mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:31.481s
[INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
[INFO] Final Memory: 66M/721M
[INFO] ------------------------------------------------------------------------


Thanks,

Alejandro Fernandez


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/
-----------------------------------------------------------

(Updated Jan. 14, 2015, 12:07 a.m.)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Mahadev Konar, Nate Cole, and Yurii Shylov.


Bugs: AMBARI-9081
    https://issues.apache.org/jira/browse/AMBARI-9081


Repository: ambari


Description
-------

See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
  ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
  ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
  ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f49 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py 71ac3df 
  ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 60f589a 

Diff: https://reviews.apache.org/r/29790/diff/


Testing
-------

Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.

```
ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
 task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
     104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
     109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
     110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
     121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
     122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
     123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
     124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
(21 rows)
```

mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:31.481s
[INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
[INFO] Final Memory: 66M/721M
[INFO] ------------------------------------------------------------------------


Thanks,

Alejandro Fernandez


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/
-----------------------------------------------------------

(Updated Jan. 14, 2015, midnight)


Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.


Changes
-------

Added unit test.


Bugs: AMBARI-9081
    https://issues.apache.org/jira/browse/AMBARI-9081


Repository: ambari


Description
-------

See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
  ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
  ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
  ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f49 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py 71ac3df 
  ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 60f589a 

Diff: https://reviews.apache.org/r/29790/diff/


Testing
-------

Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.

```
ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
 task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
     104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
     109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
     110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
     121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
     122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
     123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
     124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
(21 rows)
```

mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:31.481s
[INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
[INFO] Final Memory: 66M/721M
[INFO] ------------------------------------------------------------------------


Thanks,

Alejandro Fernandez


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/
-----------------------------------------------------------

(Updated Jan. 13, 2015, 10:16 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.


Changes
-------

Fixed agents and unit tests.


Bugs: AMBARI-9081
    https://issues.apache.org/jira/browse/AMBARI-9081


Repository: ambari


Description
-------

See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 76ba1c6 
  ambari-agent/src/test/python/resource_management/TestScript.py bff04b4 
  ambari-common/src/main/python/resource_management/libraries/script/hook.py 5c8eafc 
  ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f50 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce4 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py d54ecb9 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 7b171a8 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a625295 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8e 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 546afca 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50c 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 660a630 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb66 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda5 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd3835 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f49 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f188 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 4b11b82 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67b 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77f 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb90 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 4c450ef 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e2800 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c631 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d57983 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py 71ac3df 

Diff: https://reviews.apache.org/r/29790/diff/


Testing (updated)
-------

Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.

```
ambari=> select task_id, host_name, status, role, role_command, custom_command_name, structured_out from host_role_command where task_id >= 104 order by task_id ASC;
 task_id |        host_name        |  status   |         role         |  role_command  | custom_command_name |       structured_out
---------+-------------------------+-----------+----------------------+----------------+---------------------+-----------------------------
     104 | c6405.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     105 | c6406.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     106 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     107 | c6407.ambari.apache.org | COMPLETED | FALCON_CLIENT        | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     108 | c6406.ambari.apache.org | COMPLETED | FALCON_SERVER        | START          |                     | {"version": "2.2.1.0-2205"}
     109 | c6407.ambari.apache.org | COMPLETED | FALCON_SERVICE_CHECK | SERVICE_CHECK  |                     | {}
     110 | c6405.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     111 | c6405.ambari.apache.org | COMPLETED | HBASE_MASTER         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     112 | c6405.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     113 | c6406.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     114 | c6406.ambari.apache.org | COMPLETED | HBASE_REGIONSERVER   | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     115 | c6407.ambari.apache.org | COMPLETED | HBASE_CLIENT         | CUSTOM_COMMAND | RESTART             | {"version": "2.2.1.0-2205"}
     116 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     117 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     118 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     119 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | INSTALL        |                     | {"version": "2.2.1.0-2205"}
     120 | c6406.ambari.apache.org | COMPLETED | NIMBUS               | START          |                     | {"version": "2.2.1.0-2205"}
     121 | c6406.ambari.apache.org | COMPLETED | DRPC_SERVER          | START          |                     | {"version": "2.2.1.0-2205"}
     122 | c6406.ambari.apache.org | COMPLETED | STORM_UI_SERVER      | START          |                     | {"version": "2.2.1.0-2205"}
     123 | c6407.ambari.apache.org | COMPLETED | SUPERVISOR           | START          |                     | {"version": "2.2.1.0-2205"}
     124 | c6406.ambari.apache.org | COMPLETED | STORM_SERVICE_CHECK  | SERVICE_CHECK  |                     | {}
(21 rows)
```

mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:31.481s
[INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
[INFO] Final Memory: 66M/721M
[INFO] ------------------------------------------------------------------------


Thanks,

Alejandro Fernandez


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review67868
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Jan. 12, 2015, 9:25 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 9:25 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f378384a40026181b7d408e740fd2fcdd791 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df673dddbdd88e32577d395836b2bfa45c6 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f506e93f3f42e6e89851453e776eef38b178 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d867e0ab3bc46db39876da42b9846a681f 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce41d95faf675df183cdda48110c515b9885 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 570b1246be55e3147a17dd6927bd7f6119bf62dc 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f3cd62b47a7146d9d2e2d7df478cfbaad7 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822ea211a7a767495c1d61bde0af87b736e3 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175a3134b540122d8ca4ab99ece840d578f5 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f35093b68a5ebaffbf5bb764884f6eb630 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 6b88acb6b7ec6ea83b196ac4f501db15c8b4544b 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a62529538d0cf2770bd5c6647895f5e2530834f8 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4f938b9e61c6c46bab51554f071b0f51fa 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6d23a3fbbca9b2ce5a86de5f6db9382cbf 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8ecac052fcc9c00b808d56cd9117f8f0230 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0ac4687052510e16639f683d0f19d315ac 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50cd720645d6e10a11442d8c281df5c545d2 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5ad1a0159f3646671fc7ed28a2407e4833 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py b447003ed4b21feb4a07041c50ab19802dc687a1 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb669dd9fe360d0d35f0bbcd663a47fa5d46a 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda556db847fadf4613d583854318d6668908 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb8b0ca7cef0c5843a0cc83273d63075b37 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd38352f8bbf03ad25855f72a4563383274d07e 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f490dbbdae4c79e7e52a311a6d4582a0a030 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03a6ee8cd2ea80df0b41dc8fbe007777f79 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f18889fb724f41567f3e03edbf0a90a10a171 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6af4010f90c9b459f5ba0595d54956cd8818e21f 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67bdf2898f5779f100ff54b9a94fda2e6dba 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e080a4dc297838ee68a55ed17f70aba720 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77fe8669806e27ad7da6d12350496971e894 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb906a59fb70074272f9f33aa9bf36e844fb0 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39419ad472ea3863bc1b4517e86e89efbb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e28000049c7278a84e2b7fab732fe99d4b8bcb 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6e9182567b588816bcc83524f33028d6c0 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c6316e9f0366bbc774157d0d49a3041e0cd12 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce8c86393b7d375b65ccabd5cfaecd0980e 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d5798329d05b02ad0ce7e8878fec44782e29750 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba5d8b1662342310e65679174a9b36024b1 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> 
> mvn clean test
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:31.481s
> [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
> [INFO] Final Memory: 66M/721M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/
-----------------------------------------------------------

(Updated Jan. 12, 2015, 9:25 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.


Bugs: AMBARI-9081
    https://issues.apache.org/jira/browse/AMBARI-9081


Repository: ambari


Description
-------

See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/script/script.py af02f378384a40026181b7d408e740fd2fcdd791 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df673dddbdd88e32577d395836b2bfa45c6 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f506e93f3f42e6e89851453e776eef38b178 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d867e0ab3bc46db39876da42b9846a681f 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce41d95faf675df183cdda48110c515b9885 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 570b1246be55e3147a17dd6927bd7f6119bf62dc 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f3cd62b47a7146d9d2e2d7df478cfbaad7 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822ea211a7a767495c1d61bde0af87b736e3 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175a3134b540122d8ca4ab99ece840d578f5 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f35093b68a5ebaffbf5bb764884f6eb630 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 6b88acb6b7ec6ea83b196ac4f501db15c8b4544b 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a62529538d0cf2770bd5c6647895f5e2530834f8 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4f938b9e61c6c46bab51554f071b0f51fa 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6d23a3fbbca9b2ce5a86de5f6db9382cbf 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8ecac052fcc9c00b808d56cd9117f8f0230 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0ac4687052510e16639f683d0f19d315ac 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50cd720645d6e10a11442d8c281df5c545d2 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5ad1a0159f3646671fc7ed28a2407e4833 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py b447003ed4b21feb4a07041c50ab19802dc687a1 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb669dd9fe360d0d35f0bbcd663a47fa5d46a 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda556db847fadf4613d583854318d6668908 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb8b0ca7cef0c5843a0cc83273d63075b37 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd38352f8bbf03ad25855f72a4563383274d07e 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f490dbbdae4c79e7e52a311a6d4582a0a030 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03a6ee8cd2ea80df0b41dc8fbe007777f79 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f18889fb724f41567f3e03edbf0a90a10a171 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6af4010f90c9b459f5ba0595d54956cd8818e21f 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67bdf2898f5779f100ff54b9a94fda2e6dba 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e080a4dc297838ee68a55ed17f70aba720 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77fe8669806e27ad7da6d12350496971e894 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb906a59fb70074272f9f33aa9bf36e844fb0 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39419ad472ea3863bc1b4517e86e89efbb5 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e28000049c7278a84e2b7fab732fe99d4b8bcb 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6e9182567b588816bcc83524f33028d6c0 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c6316e9f0366bbc774157d0d49a3041e0cd12 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce8c86393b7d375b65ccabd5cfaecd0980e 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d5798329d05b02ad0ce7e8878fec44782e29750 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba5d8b1662342310e65679174a9b36024b1 

Diff: https://reviews.apache.org/r/29790/diff/


Testing (updated)
-------

Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.

mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:31.481s
[INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
[INFO] Final Memory: 66M/721M
[INFO] ------------------------------------------------------------------------


Thanks,

Alejandro Fernandez


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/
-----------------------------------------------------------

(Updated Jan. 12, 2015, 8:39 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.


Bugs: AMBARI-9081
    https://issues.apache.org/jira/browse/AMBARI-9081


Repository: ambari


Description
-------

See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/script/script.py af02f378384a40026181b7d408e740fd2fcdd791 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df673dddbdd88e32577d395836b2bfa45c6 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f506e93f3f42e6e89851453e776eef38b178 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d867e0ab3bc46db39876da42b9846a681f 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce41d95faf675df183cdda48110c515b9885 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 570b1246be55e3147a17dd6927bd7f6119bf62dc 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f3cd62b47a7146d9d2e2d7df478cfbaad7 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822ea211a7a767495c1d61bde0af87b736e3 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175a3134b540122d8ca4ab99ece840d578f5 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f35093b68a5ebaffbf5bb764884f6eb630 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 6b88acb6b7ec6ea83b196ac4f501db15c8b4544b 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a62529538d0cf2770bd5c6647895f5e2530834f8 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4f938b9e61c6c46bab51554f071b0f51fa 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6d23a3fbbca9b2ce5a86de5f6db9382cbf 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8ecac052fcc9c00b808d56cd9117f8f0230 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0ac4687052510e16639f683d0f19d315ac 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50cd720645d6e10a11442d8c281df5c545d2 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5ad1a0159f3646671fc7ed28a2407e4833 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py b447003ed4b21feb4a07041c50ab19802dc687a1 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb669dd9fe360d0d35f0bbcd663a47fa5d46a 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda556db847fadf4613d583854318d6668908 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb8b0ca7cef0c5843a0cc83273d63075b37 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd38352f8bbf03ad25855f72a4563383274d07e 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f490dbbdae4c79e7e52a311a6d4582a0a030 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03a6ee8cd2ea80df0b41dc8fbe007777f79 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f18889fb724f41567f3e03edbf0a90a10a171 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6af4010f90c9b459f5ba0595d54956cd8818e21f 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67bdf2898f5779f100ff54b9a94fda2e6dba 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e080a4dc297838ee68a55ed17f70aba720 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77fe8669806e27ad7da6d12350496971e894 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb906a59fb70074272f9f33aa9bf36e844fb0 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39419ad472ea3863bc1b4517e86e89efbb5 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e28000049c7278a84e2b7fab732fe99d4b8bcb 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6e9182567b588816bcc83524f33028d6c0 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c6316e9f0366bbc774157d0d49a3041e0cd12 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce8c86393b7d375b65ccabd5cfaecd0980e 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d5798329d05b02ad0ce7e8878fec44782e29750 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba5d8b1662342310e65679174a9b36024b1 

Diff: https://reviews.apache.org/r/29790/diff/


Testing
-------

Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
Unit test results are in-progress.


Thanks,

Alejandro Fernandez


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Nate Cole <nc...@hortonworks.com>.

> On Jan. 12, 2015, 3:13 p.m., Nate Cole wrote:
> > Many of the clients have symlinks as noted.  Fix if needed then Ship It.
> 
> Alejandro Fernandez wrote:
>     These are the component names in hdp-select, as opposed to the symlink name in /usr/hdp/current.
>     I'll investigate why they dont coincide.

Ah ok.  If this is the only way, then you can mark them all resolved and push.  Thanks!


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review67691
-----------------------------------------------------------


On Jan. 12, 2015, 4:25 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 4:25 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f378384a40026181b7d408e740fd2fcdd791 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df673dddbdd88e32577d395836b2bfa45c6 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f506e93f3f42e6e89851453e776eef38b178 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d867e0ab3bc46db39876da42b9846a681f 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce41d95faf675df183cdda48110c515b9885 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 570b1246be55e3147a17dd6927bd7f6119bf62dc 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f3cd62b47a7146d9d2e2d7df478cfbaad7 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822ea211a7a767495c1d61bde0af87b736e3 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175a3134b540122d8ca4ab99ece840d578f5 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f35093b68a5ebaffbf5bb764884f6eb630 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 6b88acb6b7ec6ea83b196ac4f501db15c8b4544b 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a62529538d0cf2770bd5c6647895f5e2530834f8 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4f938b9e61c6c46bab51554f071b0f51fa 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6d23a3fbbca9b2ce5a86de5f6db9382cbf 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8ecac052fcc9c00b808d56cd9117f8f0230 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0ac4687052510e16639f683d0f19d315ac 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50cd720645d6e10a11442d8c281df5c545d2 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5ad1a0159f3646671fc7ed28a2407e4833 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py b447003ed4b21feb4a07041c50ab19802dc687a1 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb669dd9fe360d0d35f0bbcd663a47fa5d46a 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda556db847fadf4613d583854318d6668908 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb8b0ca7cef0c5843a0cc83273d63075b37 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd38352f8bbf03ad25855f72a4563383274d07e 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f490dbbdae4c79e7e52a311a6d4582a0a030 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03a6ee8cd2ea80df0b41dc8fbe007777f79 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f18889fb724f41567f3e03edbf0a90a10a171 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6af4010f90c9b459f5ba0595d54956cd8818e21f 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67bdf2898f5779f100ff54b9a94fda2e6dba 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e080a4dc297838ee68a55ed17f70aba720 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77fe8669806e27ad7da6d12350496971e894 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb906a59fb70074272f9f33aa9bf36e844fb0 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39419ad472ea3863bc1b4517e86e89efbb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e28000049c7278a84e2b7fab732fe99d4b8bcb 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6e9182567b588816bcc83524f33028d6c0 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c6316e9f0366bbc774157d0d49a3041e0cd12 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce8c86393b7d375b65ccabd5cfaecd0980e 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d5798329d05b02ad0ce7e8878fec44782e29750 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba5d8b1662342310e65679174a9b36024b1 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> 
> mvn clean test
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:31.481s
> [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015
> [INFO] Final Memory: 66M/721M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Alejandro Fernandez <af...@hortonworks.com>.

> On Jan. 12, 2015, 8:13 p.m., Nate Cole wrote:
> > Many of the clients have symlinks as noted.  Fix if needed then Ship It.

These are the component names in hdp-select, as opposed to the symlink name in /usr/hdp/current.
I'll investigate why they dont coincide.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review67691
-----------------------------------------------------------


On Jan. 12, 2015, 8:39 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 8:39 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f378384a40026181b7d408e740fd2fcdd791 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df673dddbdd88e32577d395836b2bfa45c6 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f506e93f3f42e6e89851453e776eef38b178 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d867e0ab3bc46db39876da42b9846a681f 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce41d95faf675df183cdda48110c515b9885 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 570b1246be55e3147a17dd6927bd7f6119bf62dc 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f3cd62b47a7146d9d2e2d7df478cfbaad7 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822ea211a7a767495c1d61bde0af87b736e3 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175a3134b540122d8ca4ab99ece840d578f5 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f35093b68a5ebaffbf5bb764884f6eb630 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 6b88acb6b7ec6ea83b196ac4f501db15c8b4544b 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a62529538d0cf2770bd5c6647895f5e2530834f8 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4f938b9e61c6c46bab51554f071b0f51fa 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6d23a3fbbca9b2ce5a86de5f6db9382cbf 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8ecac052fcc9c00b808d56cd9117f8f0230 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0ac4687052510e16639f683d0f19d315ac 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50cd720645d6e10a11442d8c281df5c545d2 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5ad1a0159f3646671fc7ed28a2407e4833 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py b447003ed4b21feb4a07041c50ab19802dc687a1 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb669dd9fe360d0d35f0bbcd663a47fa5d46a 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda556db847fadf4613d583854318d6668908 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb8b0ca7cef0c5843a0cc83273d63075b37 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd38352f8bbf03ad25855f72a4563383274d07e 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f490dbbdae4c79e7e52a311a6d4582a0a030 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03a6ee8cd2ea80df0b41dc8fbe007777f79 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f18889fb724f41567f3e03edbf0a90a10a171 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6af4010f90c9b459f5ba0595d54956cd8818e21f 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67bdf2898f5779f100ff54b9a94fda2e6dba 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e080a4dc297838ee68a55ed17f70aba720 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77fe8669806e27ad7da6d12350496971e894 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb906a59fb70074272f9f33aa9bf36e844fb0 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39419ad472ea3863bc1b4517e86e89efbb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e28000049c7278a84e2b7fab732fe99d4b8bcb 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6e9182567b588816bcc83524f33028d6c0 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c6316e9f0366bbc774157d0d49a3041e0cd12 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce8c86393b7d375b65ccabd5cfaecd0980e 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d5798329d05b02ad0ce7e8878fec44782e29750 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba5d8b1662342310e65679174a9b36024b1 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> Unit test results are in-progress.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review67691
-----------------------------------------------------------

Ship it!


Many of the clients have symlinks as noted.  Fix if needed then Ship It.


ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
<https://reviews.apache.org/r/29790/#comment111773>

    I /usr/hdp/current/hive-client for Hive.



ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py
<https://reviews.apache.org/r/29790/#comment111774>

    /usr/hdp/current/pig-client



ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py
<https://reviews.apache.org/r/29790/#comment111775>

    /usr/hdp/current/tez-client



ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
<https://reviews.apache.org/r/29790/#comment111776>

    Could this be /usr/hdp/current/hadoop-mapreduce-client ?



ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
<https://reviews.apache.org/r/29790/#comment111777>

    /usr/hdp/current/hadoop-yarn-client


- Nate Cole


On Jan. 12, 2015, 2:35 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 2:35 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f378384a40026181b7d408e740fd2fcdd791 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df673dddbdd88e32577d395836b2bfa45c6 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f506e93f3f42e6e89851453e776eef38b178 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d867e0ab3bc46db39876da42b9846a681f 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce41d95faf675df183cdda48110c515b9885 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 570b1246be55e3147a17dd6927bd7f6119bf62dc 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f3cd62b47a7146d9d2e2d7df478cfbaad7 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822ea211a7a767495c1d61bde0af87b736e3 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175a3134b540122d8ca4ab99ece840d578f5 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f35093b68a5ebaffbf5bb764884f6eb630 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 6b88acb6b7ec6ea83b196ac4f501db15c8b4544b 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a62529538d0cf2770bd5c6647895f5e2530834f8 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4f938b9e61c6c46bab51554f071b0f51fa 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6d23a3fbbca9b2ce5a86de5f6db9382cbf 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8ecac052fcc9c00b808d56cd9117f8f0230 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0ac4687052510e16639f683d0f19d315ac 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50cd720645d6e10a11442d8c281df5c545d2 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5ad1a0159f3646671fc7ed28a2407e4833 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py b447003ed4b21feb4a07041c50ab19802dc687a1 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb669dd9fe360d0d35f0bbcd663a47fa5d46a 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda556db847fadf4613d583854318d6668908 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb8b0ca7cef0c5843a0cc83273d63075b37 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd38352f8bbf03ad25855f72a4563383274d07e 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f490dbbdae4c79e7e52a311a6d4582a0a030 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03a6ee8cd2ea80df0b41dc8fbe007777f79 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f18889fb724f41567f3e03edbf0a90a10a171 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6af4010f90c9b459f5ba0595d54956cd8818e21f 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67bdf2898f5779f100ff54b9a94fda2e6dba 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e080a4dc297838ee68a55ed17f70aba720 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77fe8669806e27ad7da6d12350496971e894 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb906a59fb70074272f9f33aa9bf36e844fb0 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39419ad472ea3863bc1b4517e86e89efbb5 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e28000049c7278a84e2b7fab732fe99d4b8bcb 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6e9182567b588816bcc83524f33028d6c0 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c6316e9f0366bbc774157d0d49a3041e0cd12 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce8c86393b7d375b65ccabd5cfaecd0980e 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d5798329d05b02ad0ce7e8878fec44782e29750 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba5d8b1662342310e65679174a9b36024b1 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
> Unit test results are in-progress.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/
-----------------------------------------------------------

(Updated Jan. 12, 2015, 7:35 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.


Changes
-------

Revised based on Nate's suggestion.


Bugs: AMBARI-9081
    https://issues.apache.org/jira/browse/AMBARI-9081


Repository: ambari


Description
-------

See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/script/script.py af02f378384a40026181b7d408e740fd2fcdd791 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df673dddbdd88e32577d395836b2bfa45c6 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f506e93f3f42e6e89851453e776eef38b178 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d867e0ab3bc46db39876da42b9846a681f 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce41d95faf675df183cdda48110c515b9885 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 570b1246be55e3147a17dd6927bd7f6119bf62dc 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f3cd62b47a7146d9d2e2d7df478cfbaad7 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822ea211a7a767495c1d61bde0af87b736e3 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175a3134b540122d8ca4ab99ece840d578f5 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f35093b68a5ebaffbf5bb764884f6eb630 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 6b88acb6b7ec6ea83b196ac4f501db15c8b4544b 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a62529538d0cf2770bd5c6647895f5e2530834f8 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4f938b9e61c6c46bab51554f071b0f51fa 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6d23a3fbbca9b2ce5a86de5f6db9382cbf 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8ecac052fcc9c00b808d56cd9117f8f0230 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0ac4687052510e16639f683d0f19d315ac 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50cd720645d6e10a11442d8c281df5c545d2 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5ad1a0159f3646671fc7ed28a2407e4833 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py b447003ed4b21feb4a07041c50ab19802dc687a1 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb669dd9fe360d0d35f0bbcd663a47fa5d46a 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda556db847fadf4613d583854318d6668908 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb8b0ca7cef0c5843a0cc83273d63075b37 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd38352f8bbf03ad25855f72a4563383274d07e 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f490dbbdae4c79e7e52a311a6d4582a0a030 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03a6ee8cd2ea80df0b41dc8fbe007777f79 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f18889fb724f41567f3e03edbf0a90a10a171 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6af4010f90c9b459f5ba0595d54956cd8818e21f 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67bdf2898f5779f100ff54b9a94fda2e6dba 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e080a4dc297838ee68a55ed17f70aba720 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77fe8669806e27ad7da6d12350496971e894 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb906a59fb70074272f9f33aa9bf36e844fb0 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39419ad472ea3863bc1b4517e86e89efbb5 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e28000049c7278a84e2b7fab732fe99d4b8bcb 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6e9182567b588816bcc83524f33028d6c0 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c6316e9f0366bbc774157d0d49a3041e0cd12 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce8c86393b7d375b65ccabd5cfaecd0980e 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d5798329d05b02ad0ce7e8878fec44782e29750 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba5d8b1662342310e65679174a9b36024b1 

Diff: https://reviews.apache.org/r/29790/diff/


Testing
-------

Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table.
Unit test results are in-progress.


Thanks,

Alejandro Fernandez