You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/12/23 10:18:17 UTC

[GitHub] [inlong] bluewang opened a new pull request, #7044: [INLONG-7043][Dashboard] Es sink Add field prompt

bluewang opened a new pull request, #7044:
URL: https://github.com/apache/inlong/pull/7044

   ### Prepare a Pull Request
   *(Change the title refer to the following example)*
   
   - Title Example: [INLONG-XYZ][Component] Title of the pull request
   
   *(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
   
   - Fixes https://github.com/apache/inlong/issues/7043
   
   
   ### Modifications
   ![image](https://user-images.githubusercontent.com/88174078/209318240-0496e5cc-6ffe-493d-91bb-3046bd447194.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #7044: [INLONG-7043][Dashboard] Add field prompt for ES sink

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #7044:
URL: https://github.com/apache/inlong/pull/7044#discussion_r1056770659


##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -167,6 +167,7 @@
   "meta.Sinks.ES.RetryTimes": "重试次数",
   "meta.Sinks.ES.RetryTimesUnit": "次",
   "meta.Sinks.ES.EsVersion": "Elasticsearch 版本",
+  "meta.Sinks.ES.EsVersionHelp": "此处 Elasticsearch 版本为大版本号",

Review Comment:
   Is the following comment correct?
   ```suggestion
     "meta.Sinks.ES.EsVersionHelp": "填写大版本号，如：对于7.5.2版本，填写7即可",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang commented on a diff in pull request #7044: [INLONG-7043][Dashboard] Add field prompt for ES sink

Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #7044:
URL: https://github.com/apache/inlong/pull/7044#discussion_r1057150296


##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -167,6 +167,7 @@
   "meta.Sinks.ES.RetryTimes": "重试次数",
   "meta.Sinks.ES.RetryTimesUnit": "次",
   "meta.Sinks.ES.EsVersion": "Elasticsearch 版本",
+  "meta.Sinks.ES.EsVersionHelp": "此处 Elasticsearch 版本为大版本号",

Review Comment:
   ```suggestion
     "meta.Sinks.ES.EsVersionHelp": "Elasticsearch 大版本号，比如 5/6/7",
   ```



##########
inlong-dashboard/src/locales/en.json:
##########
@@ -167,6 +167,7 @@
   "meta.Sinks.ES.RetryTimes": "RetryTimes",
   "meta.Sinks.ES.RetryTimesUnit": "items",
   "meta.Sinks.ES.EsVersion": "Elasticsearch Version",
+  "meta.Sinks.ES.EsVersionHelp": "Here the Elasticsearch version is the major version number",

Review Comment:
   ```suggestion
     "meta.Sinks.ES.EsVersionHelp": "Elasticsearch major version number, such as 5/6/7",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang commented on a diff in pull request #7044: [INLONG-7043][Dashboard] Add field prompt for ES sink

Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #7044:
URL: https://github.com/apache/inlong/pull/7044#discussion_r1056824666


##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -167,6 +167,7 @@
   "meta.Sinks.ES.RetryTimes": "重试次数",
   "meta.Sinks.ES.RetryTimesUnit": "次",
   "meta.Sinks.ES.EsVersion": "Elasticsearch 版本",
+  "meta.Sinks.ES.EsVersionHelp": "此处 Elasticsearch 版本为大版本号",

Review Comment:
   Maybe we can add a drop-down selection box. The options include all supported versions, such as 5/6/7.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang commented on a diff in pull request #7044: [INLONG-7043][Dashboard] Add field prompt for ES sink

Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #7044:
URL: https://github.com/apache/inlong/pull/7044#discussion_r1056822957


##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -167,6 +167,7 @@
   "meta.Sinks.ES.RetryTimes": "重试次数",
   "meta.Sinks.ES.RetryTimesUnit": "次",
   "meta.Sinks.ES.EsVersion": "Elasticsearch 版本",
+  "meta.Sinks.ES.EsVersionHelp": "此处 Elasticsearch 版本为大版本号",

Review Comment:
   like 5,6,7



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #7044: [INLONG-7043][Dashboard] Add field prompt for ES sink

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #7044:
URL: https://github.com/apache/inlong/pull/7044#discussion_r1056897453


##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -167,6 +167,7 @@
   "meta.Sinks.ES.RetryTimes": "重试次数",
   "meta.Sinks.ES.RetryTimesUnit": "次",
   "meta.Sinks.ES.EsVersion": "Elasticsearch 版本",
+  "meta.Sinks.ES.EsVersionHelp": "此处 Elasticsearch 版本为大版本号",

Review Comment:
   This is a good way.
   However, there will be too much coupling: if the versions supported by the background become more or less, the front end needs to be modified.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang merged pull request #7044: [INLONG-7043][Dashboard] Add field prompt for ES sink

Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #7044:
URL: https://github.com/apache/inlong/pull/7044


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang commented on a diff in pull request #7044: [INLONG-7043][Dashboard] Add field prompt for ES sink

Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #7044:
URL: https://github.com/apache/inlong/pull/7044#discussion_r1057149312


##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -167,6 +167,7 @@
   "meta.Sinks.ES.RetryTimes": "重试次数",
   "meta.Sinks.ES.RetryTimesUnit": "次",
   "meta.Sinks.ES.EsVersion": "Elasticsearch 版本",
+  "meta.Sinks.ES.EsVersionHelp": "此处 Elasticsearch 版本为大版本号",

Review Comment:
   We can deal with it simply and only give a clear reminder.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #7044: [INLONG-7043][Dashboard] Add field prompt for ES sink

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #7044:
URL: https://github.com/apache/inlong/pull/7044#discussion_r1056897482


##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -167,6 +167,7 @@
   "meta.Sinks.ES.RetryTimes": "重试次数",
   "meta.Sinks.ES.RetryTimesUnit": "次",
   "meta.Sinks.ES.EsVersion": "Elasticsearch 版本",
+  "meta.Sinks.ES.EsVersionHelp": "此处 Elasticsearch 版本为大版本号",

Review Comment:
   This limitation is recommended to be placed on the Manager side. It is filled in by the user and verified by the Manager module when saving. If there is any error, the error will be thrown directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org