You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "fresh-borzoni (via GitHub)" <gi...@apache.org> on 2026/06/08 13:58:37 UTC
Re: [PR] [FLINK-38579] [table-planner] Fix incorrect UB drop for filter on non-upsert key [flink]
fresh-borzoni commented on code in PR #28090:
URL: https://github.com/apache/flink/pull/28090#discussion_r3373764502
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkChangelogModeInferenceProgram.scala:
##########
@@ -1303,27 +1319,35 @@ class FlinkChangelogModeInferenceProgram extends FlinkOptimizeProgram[StreamOpti
createNewNode(process, Some(children), providedDeleteTrait)
case join: StreamPhysicalJoin =>
Review Comment:
Good call. Added guards for MultiJoin, TemporalJoin, LookupJoin and Correlate. Interval/Window joins can't hit this, their inputs are append-only, so there's no UB to drop.
For ChangelogNormalize I didn't add a guard, but instead it now falls back to accepting BEFORE_AND_AFTER from its child when UA-only isn't possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org