You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2023/03/17 12:10:44 UTC
[GitHub] [superset] kgabryje opened a new pull request, #23410: feat(echarts): Implement stream graph for Area chart
kgabryje opened a new pull request, #23410:
URL: https://github.com/apache/superset/pull/23410
### SUMMARY
Echarts don't support stream graph for area chart. This PR implements stream graph for Echarts Area and Echarts Bar charts to achieve feature parity with legacy NVD3 charts.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Stream graph area chart:
Stream graph bar chart:
Stream graph area chart with categorical x axis:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #23410: feat(echarts): Implement stream graph for Echarts Timeseries
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #23410:
URL: https://github.com/apache/superset/pull/23410#issuecomment-1474166041
Getting ready to kill NVD3..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #23410: feat(echarts): Implement stream graph for Area chart
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #23410:
URL: https://github.com/apache/superset/pull/23410#issuecomment-1473929132
Thanks for comments @villebro, updated the PR. Now all timeseries echarts support stream graph :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23410: feat(echarts): Implement stream graph for Area chart
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23410:
URL: https://github.com/apache/superset/pull/23410#issuecomment-1473801486
## [Codecov](https://codecov.io/gh/apache/superset/pull/23410?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23410](https://codecov.io/gh/apache/superset/pull/23410?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f0bb1d) into [master](https://codecov.io/gh/apache/superset/commit/e3a7d2014df179088e14a5fc953dc66f69ba0f04?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3a7d20) will **decrease** coverage by `11.23%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 9f0bb1d differs from pull request most recent head c5c202f. Consider uploading reports for the commit c5c202f to get more accurate results
```diff
@@ Coverage Diff @@
## master #23410 +/- ##
===========================================
- Coverage 67.49% 56.27% -11.23%
===========================================
Files 1907 1907
Lines 73531 73506 -25
Branches 7981 7974 -7
===========================================
- Hits 49633 41365 -8268
- Misses 21850 30099 +8249
+ Partials 2048 2042 -6
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.68% <ø> (ø)` | |
| python | `58.89% <ø> (-23.23%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.48% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...chart-echarts/src/Timeseries/Area/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/23410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9BcmVhL2NvbnRyb2xQYW5lbC50c3g=) | `40.00% <ø> (ø)` | |
| [...charts/src/Timeseries/Regular/Bar/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/23410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL0Jhci9jb250cm9sUGFuZWwudHN4) | `35.71% <ø> (ø)` | |
| [...gin-chart-echarts/src/Timeseries/transformProps.ts](https://codecov.io/gh/apache/superset/pull/23410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1Qcm9wcy50cw==) | `57.29% <ø> (+0.14%)` | :arrow_up: |
| [...lugin-chart-echarts/src/Timeseries/transformers.ts](https://codecov.io/gh/apache/superset/pull/23410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1lcnMudHM=) | `50.79% <ø> (+0.40%)` | :arrow_up: |
| [...tend/plugins/plugin-chart-echarts/src/constants.ts](https://codecov.io/gh/apache/superset/pull/23410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvY29uc3RhbnRzLnRz) | `100.00% <ø> (ø)` | |
| [...tend/plugins/plugin-chart-echarts/src/controls.tsx](https://codecov.io/gh/apache/superset/pull/23410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvY29udHJvbHMudHN4) | `75.00% <ø> (-1.00%)` | :arrow_down: |
| [...d/plugins/plugin-chart-echarts/src/utils/series.ts](https://codecov.io/gh/apache/superset/pull/23410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvdXRpbHMvc2VyaWVzLnRz) | `87.68% <ø> (+0.63%)` | :arrow_up: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/23410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `63.33% <ø> (+0.51%)` | :arrow_up: |
... and [301 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23410/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #23410: feat(echarts): Implement stream graph for Echarts Timeseries
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #23410:
URL: https://github.com/apache/superset/pull/23410#discussion_r1140515936
##########
superset-frontend/plugins/plugin-chart-echarts/src/constants.ts:
##########
@@ -71,18 +71,29 @@ export enum OpacityEnum {
NonTransparent = 1,
}
-export enum AreaChartExtraControlsValue {
+export enum StackControlsValue {
Stack = 'Stack',
+ Stream = 'Stream',
Expand = 'Expand',
}
+export const ExtraControlsOptions: [
+ JsonValue,
+ Exclude<ReactNode, null | undefined | boolean>,
+][] = [
+ [null, t('None')],
+ [StackControlsValue.Stack, t('Stack')],
+ [StackControlsValue.Stream, t('Stream')],
+];
+
export const AreaChartExtraControlsOptions: [
JsonValue,
Exclude<ReactNode, null | undefined | boolean>,
][] = [
[null, t('None')],
- [AreaChartExtraControlsValue.Stack, t('Stack')],
- [AreaChartExtraControlsValue.Expand, t('Expand')],
+ [StackControlsValue.Stack, t('Stack')],
+ [StackControlsValue.Stream, t('Stream')],
+ [StackControlsValue.Expand, t('Expand')],
];
Review Comment:
While we're at it, could we spread the former into the latter to DRY it up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #23410: feat(echarts): Implement stream graph for Echarts Timeseries
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #23410:
URL: https://github.com/apache/superset/pull/23410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #23410: feat(echarts): Implement stream graph for Area chart
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #23410:
URL: https://github.com/apache/superset/pull/23410#issuecomment-1473743162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23410: feat(echarts): Implement stream graph for Echarts Timeseries
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23410:
URL: https://github.com/apache/superset/pull/23410#issuecomment-1476565382
LOVE this :) Nice work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #23410: feat(echarts): Implement stream graph for Area chart
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #23410:
URL: https://github.com/apache/superset/pull/23410#discussion_r1140163690
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts:
##########
@@ -64,11 +68,78 @@ import {
} from '../utils/annotation';
import { currentSeries, getChartPadding } from '../utils/series';
import {
- AreaChartExtraControlsValue,
OpacityEnum,
+ StackControlsValue,
TIMESERIES_CONSTANTS,
} from '../constants';
+// based on weighted wiggle algorithm
+export const getBaselineSeriesForStream = (
+ series: [string | number, number][][],
+ seriesType: EchartsTimeseriesSeriesType,
+) => {
Review Comment:
Could we add a simple test case for this?
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts:
##########
@@ -64,11 +68,78 @@ import {
} from '../utils/annotation';
import { currentSeries, getChartPadding } from '../utils/series';
import {
- AreaChartExtraControlsValue,
OpacityEnum,
+ StackControlsValue,
TIMESERIES_CONSTANTS,
} from '../constants';
+// based on weighted wiggle algorithm
Review Comment:
can we add a reference to the source?
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx:
##########
@@ -37,10 +37,13 @@ import {
} from '../../constants';
import {
legendSection,
+ onlyTotalControl,
+ percentageThresholdControl,
richTooltipSection,
seriesOrderSection,
- showValueSection,
+ showValueControl,
} from '../../../controls';
+import { BarChartExtraControlsOptions } from '../../../constants';
Review Comment:
bycatch, many '../..' in the imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #23410: feat(echarts): Implement stream graph for Area chart
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #23410:
URL: https://github.com/apache/superset/pull/23410#issuecomment-1473797591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #23410: feat(echarts): Implement stream graph for Area chart
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #23410:
URL: https://github.com/apache/superset/pull/23410#issuecomment-1474111535
@villebro For some reason the updated import paths (import from `@superset-ui/plugin-chart-echarts` instead of `../../../controls`) broke the unit tests. I reverted the change to unblock the CI. We can try to resolve it in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #23410: feat(echarts): Implement stream graph for Echarts Timeseries
Posted by "stephenLYZ (via GitHub)" <gi...@apache.org>.
stephenLYZ commented on PR #23410:
URL: https://github.com/apache/superset/pull/23410#issuecomment-1476101346
OMG. It's amazing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #23410: feat(echarts): Implement stream graph for Area chart
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #23410:
URL: https://github.com/apache/superset/pull/23410#issuecomment-1474136494
> @villebro For some reason the updated import paths (import from `@superset-ui/plugin-chart-echarts` instead of `../../../controls`) broke the unit tests. I reverted the change to unblock the CI. We can try to resolve it in a separate PR
Oof, my bad, I totally forgot those tests want those relative imports.. Carry on!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #23410: feat(echarts): Implement stream graph for Echarts Timeseries
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #23410:
URL: https://github.com/apache/superset/pull/23410#discussion_r1140502511
##########
superset-frontend/plugins/plugin-chart-echarts/src/constants.ts:
##########
@@ -71,18 +71,29 @@ export enum OpacityEnum {
NonTransparent = 1,
}
-export enum AreaChartExtraControlsValue {
+export enum StackControlsValue {
Stack = 'Stack',
+ Stream = 'Stream',
Expand = 'Expand',
}
+export const ExtraControlsOptions: [
+ JsonValue,
+ Exclude<ReactNode, null | undefined | boolean>,
+][] = [
+ [null, t('None')],
+ [StackControlsValue.Stack, t('Stack')],
+ [StackControlsValue.Stream, t('Stream')],
+];
+
export const AreaChartExtraControlsOptions: [
JsonValue,
Exclude<ReactNode, null | undefined | boolean>,
][] = [
[null, t('None')],
- [AreaChartExtraControlsValue.Stack, t('Stack')],
- [AreaChartExtraControlsValue.Expand, t('Expand')],
+ [StackControlsValue.Stack, t('Stack')],
+ [StackControlsValue.Stream, t('Stream')],
+ [StackControlsValue.Expand, t('Expand')],
];
Review Comment:
Maybe a nit, but this had me confused: could these be called `StackControlOptions` and `AreaChartStackControlOptions`?
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx:
##########
@@ -116,6 +117,7 @@ const config: ControlPanelConfig = {
},
],
[onlyTotalControl],
+ [percentageThresholdControl],
Review Comment:
Oh nice bycatch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #23410: feat(echarts): Implement stream graph for Echarts Timeseries
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #23410:
URL: https://github.com/apache/superset/pull/23410#issuecomment-1474167104
> Getting ready to kill NVD3.. 
I'll bring the garlic!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #23410: feat(echarts): Implement stream graph for Area chart
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #23410:
URL: https://github.com/apache/superset/pull/23410#discussion_r1140210261
##########
superset/migrations/versions/2023-03-17_13-24_b5ea9d343307_bar_chart_stack_options.py:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""bar_chart_stack_options
+
+Revision ID: b5ea9d343307
+Revises: d0ac08bb5b83
+Create Date: 2023-03-17 13:24:54.662754
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "b5ea9d343307"
+down_revision = "d0ac08bb5b83"
+
+import json
+
+import sqlalchemy as sa
+from alembic import op
+from sqlalchemy import and_, Column, Integer, String, Text
+from sqlalchemy.ext.declarative import declarative_base
+
+from superset import db
+
+Base = declarative_base()
+
+CHART_TYPE = "echarts_timeseries_bar"
Review Comment:
shouldn't we also migrate the other ECharts "timeseries" like plugins to use the new select-based control? Here I'm using the ECharts "Generic Chart", and the stack control is still a checkbox:
<img width="806" alt="image" src="https://user-images.githubusercontent.com/33317356/225912090-ec9e5bf2-70f4-4aa2-8cd4-852dccb3c262.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org