You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Benoit Lafontaine (JIRA)" <ji...@apache.org> on 2007/08/27 17:31:30 UTC
[jira] Created: (DBCP-238) The BasicDataSource setLoginTimeout and
getLoginTimeout are not supported
The BasicDataSource setLoginTimeout and getLoginTimeout are not supported
-------------------------------------------------------------------------
Key: DBCP-238
URL: https://issues.apache.org/jira/browse/DBCP-238
Project: Commons Dbcp
Issue Type: Bug
Affects Versions: 1.2.2
Reporter: Benoit Lafontaine
Methods setLoginTimeout() and getLoginTimeout() are not supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DBCP-238) The BasicDataSource setLoginTimeout and
getLoginTimeout are not supported
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz closed DBCP-238.
----------------------------
> The BasicDataSource setLoginTimeout and getLoginTimeout are not supported
> -------------------------------------------------------------------------
>
> Key: DBCP-238
> URL: https://issues.apache.org/jira/browse/DBCP-238
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 1.2.2
> Reporter: Benoit Lafontaine
> Fix For: 1.3
>
> Attachments: DBCP-238.patch
>
>
> Methods setLoginTimeout() and getLoginTimeout() are not supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DBCP-238) The BasicDataSource setLoginTimeout and
getLoginTimeout are not supported
Posted by "Benoit Lafontaine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benoit Lafontaine updated DBCP-238:
-----------------------------------
Attachment: DBCP-238.patch
This patch try to add the loginTimeout feature.
This is made by creating another thread that will call the _driver.connect(_connectUri, _props);
The main thread will wait for it by using the Thread.join(timeout) method.
If the join method returns by timeout and the connect didn't finished, then the main method will throw an SQLException "timeout".
Anyway, for the moment, the second Thread will not be stopped, even if the Thread.interrupted() method is called.
> The BasicDataSource setLoginTimeout and getLoginTimeout are not supported
> -------------------------------------------------------------------------
>
> Key: DBCP-238
> URL: https://issues.apache.org/jira/browse/DBCP-238
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 1.2.2
> Reporter: Benoit Lafontaine
> Attachments: DBCP-238.patch
>
>
> Methods setLoginTimeout() and getLoginTimeout() are not supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DBCP-238) The BasicDataSource setLoginTimeout and
getLoginTimeout are not supported
Posted by "Mark Thomas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Thomas resolved DBCP-238.
------------------------------
Resolution: Won't Fix
I agree with Phil's analysis. Therefore, resolving as WONTFIX.
> The BasicDataSource setLoginTimeout and getLoginTimeout are not supported
> -------------------------------------------------------------------------
>
> Key: DBCP-238
> URL: https://issues.apache.org/jira/browse/DBCP-238
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 1.2.2
> Reporter: Benoit Lafontaine
> Fix For: 1.3
>
> Attachments: DBCP-238.patch
>
>
> Methods setLoginTimeout() and getLoginTimeout() are not supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DBCP-238) The BasicDataSource setLoginTimeout and
getLoginTimeout are not supported
Posted by "Benoit Lafontaine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benoit Lafontaine updated DBCP-238:
-----------------------------------
Fix Version/s: 1.3
> The BasicDataSource setLoginTimeout and getLoginTimeout are not supported
> -------------------------------------------------------------------------
>
> Key: DBCP-238
> URL: https://issues.apache.org/jira/browse/DBCP-238
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 1.2.2
> Reporter: Benoit Lafontaine
> Fix For: 1.3
>
> Attachments: DBCP-238.patch
>
>
> Methods setLoginTimeout() and getLoginTimeout() are not supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DBCP-238) The BasicDataSource setLoginTimeout
and getLoginTimeout are not supported
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688038#action_12688038 ]
Phil Steitz commented on DBCP-238:
----------------------------------
I see four alternatives here. If others have better ideas, please chime in.
1) Apply cleaned up version of the patch.
2) Add a loginTimeout property to BDS, DCF and pass it to the driver as a property.
3) View this as synonymous with maxWait (modulo unit difference)
4) WONTFIX
I don't like the idea of spawning a thread in 1), 2) can already be accomplished in the connect string, 3) is redundant, so unless someone has a better idea, I think we should close as WONTFIX.
> The BasicDataSource setLoginTimeout and getLoginTimeout are not supported
> -------------------------------------------------------------------------
>
> Key: DBCP-238
> URL: https://issues.apache.org/jira/browse/DBCP-238
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 1.2.2
> Reporter: Benoit Lafontaine
> Fix For: 1.3
>
> Attachments: DBCP-238.patch
>
>
> Methods setLoginTimeout() and getLoginTimeout() are not supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.