You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/04 18:23:40 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request #676: Implement metrics for shuffle read and write
andygrove opened a new pull request #676:
URL: https://github.com/apache/arrow-datafusion/pull/676
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #675 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
More metrics.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
More metrics in query plan.
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on a change in pull request #676: Implement metrics for shuffle read and write
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #676:
URL: https://github.com/apache/arrow-datafusion/pull/676#discussion_r663543300
##########
File path: ballista/rust/core/Cargo.toml
##########
@@ -33,6 +33,7 @@ simd = ["datafusion/simd"]
ahash = "0.7"
async-trait = "0.1.36"
futures = "0.3"
+hashbrown = "0.11"
Review comment:
From the official readme:
> Since Rust 1.36, this is now the HashMap implementation for the Rust standard library. However you may still want to use this crate instead since it works in environments without std, such as embedded systems and kernels.
Are we introducing it because we are expecting to use ballista in embedded systems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #676: Implement metrics for shuffle read and write
Posted by GitBox <gi...@apache.org>.
Dandandan commented on a change in pull request #676:
URL: https://github.com/apache/arrow-datafusion/pull/676#discussion_r663672019
##########
File path: ballista/rust/core/Cargo.toml
##########
@@ -33,6 +33,7 @@ simd = ["datafusion/simd"]
ahash = "0.7"
async-trait = "0.1.36"
futures = "0.3"
+hashbrown = "0.11"
Review comment:
Added some comments on the ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on a change in pull request #676: Implement metrics for shuffle read and write
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #676:
URL: https://github.com/apache/arrow-datafusion/pull/676#discussion_r663545596
##########
File path: ballista/rust/core/Cargo.toml
##########
@@ -33,6 +33,7 @@ simd = ["datafusion/simd"]
ahash = "0.7"
async-trait = "0.1.36"
futures = "0.3"
+hashbrown = "0.11"
Review comment:
Filed https://github.com/apache/arrow-datafusion/issues/677 as a follow up so we don't block the merge of this PR. I am curious whether the std hashmap also uses ahash as the default hasher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on a change in pull request #676: Implement metrics for shuffle read and write
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #676:
URL: https://github.com/apache/arrow-datafusion/pull/676#discussion_r663543300
##########
File path: ballista/rust/core/Cargo.toml
##########
@@ -33,6 +33,7 @@ simd = ["datafusion/simd"]
ahash = "0.7"
async-trait = "0.1.36"
futures = "0.3"
+hashbrown = "0.11"
Review comment:
From the official readme:
```
Since Rust 1.36, this is now the HashMap implementation for the Rust standard library. However you may still want to use this crate instead since it works in environments without std, such as embedded systems and kernels.
```
Are we introducing it because we are expecting to use ballista in embedded systems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a change in pull request #676: Implement metrics for shuffle read and write
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #676:
URL: https://github.com/apache/arrow-datafusion/pull/676#discussion_r663544711
##########
File path: ballista/rust/core/Cargo.toml
##########
@@ -33,6 +33,7 @@ simd = ["datafusion/simd"]
ahash = "0.7"
async-trait = "0.1.36"
futures = "0.3"
+hashbrown = "0.11"
Review comment:
It looks like the dependency was added to DataFusion for a performance optimization in https://github.com/apache/arrow-datafusion/commit/ec062075cd03fc68e22b96d6f8bf0ed291e30d93 and when the `metrics` method was added in DataFusion is used this hashmap as well, but perhaps we should have had it use the std hashmap instead?
@Dandandan what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan merged pull request #676: Implement metrics for shuffle read and write
Posted by GitBox <gi...@apache.org>.
Dandandan merged pull request #676:
URL: https://github.com/apache/arrow-datafusion/pull/676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org