[jira] [Commented] (GEOMETRY-38) Check unit test - line intersecting cube

["Matt Juntunen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEOMETRY-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751821#comment-16751821 ] 

Matt Juntunen commented on GEOMETRY-38:
---------------------------------------

Hi. Thanks for your interest in commons-geometry!

In response to your question on your PR, you are indeed using the library correctly. This is a bona fide bug. The intersection logic in {{PolyhedronSet.boundaryFacet()}} was only returning the facet if the intersection point was on the inside of the facet. Thus, if the point was on the boundary, it would not be returned. I've fixed this in the PR below and add a unit test based on what you had.

On a side note, if you're interested in commons-geometry, we are currently in the process of rewriting large chunks of it. There are Jira issues for most of the major updates that we'd like to make, but feel free to add an issue if you think something is missing. There are also plenty of things that need doing if you'd like to go so far as contribute.

Thanks again!

Pull request: https://github.com/apache/commons-geometry/pull/21

> Check unit test - line intersecting cube
> ----------------------------------------
>
>                 Key: GEOMETRY-38
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-38
>             Project: Apache Commons Geometry
>          Issue Type: Task
>          Components: Euclidean 3D
>            Reporter: Sven Rathgeber
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Intersecting a cube (PolyhedronsSet) with a Line diagonally results in null.
> Please check the pull request:
> https://github.com/apache/commons-geometry/pull/19



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)