You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2026/04/24 05:59:36 UTC

[Impala-ASF-CR] IMPALA-14919: Deflake TestSelfRenameEvent.test self rename event

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24233


Change subject: IMPALA-14919: Deflake TestSelfRenameEvent.test_self_rename_event
......................................................................

IMPALA-14919: Deflake TestSelfRenameEvent.test_self_rename_event

The test pauses event-processor after executing an ALTER TABLE RENAME
statement, assuming the event will be processed later after that. That's
flaky since the event could actually be processed before the pause
command. Then the first fetch on 'events-skipped' metric happens too
late, e.g., events_skipped_before already counts the first ALTER_TABLE
event.

This patch fixes the issue by fetching the 'events-skipped' metric
before executing the first ALTER TABLE RENAME statement. This ensures
the two ALTER events are processed after that.

Tests:
Ran the test locally 60 times.

Change-Id: I9a5f3573cce4329e2ff35eaaf46586a65b9eb461
---
M tests/metadata/test_event_processing.py
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/24233/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a5f3573cce4329e2ff35eaaf46586a65b9eb461
Gerrit-Change-Number: 24233
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-14919: Deflake TestSelfRenameEvent.test self rename event

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24233 )

Change subject: IMPALA-14919: Deflake TestSelfRenameEvent.test_self_rename_event
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13387/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a5f3573cce4329e2ff35eaaf46586a65b9eb461
Gerrit-Change-Number: 24233
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Apr 2026 05:54:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14919: Deflake TestSelfRenameEvent.test self rename event

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24233 )

Change subject: IMPALA-14919: Deflake TestSelfRenameEvent.test_self_rename_event
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a5f3573cce4329e2ff35eaaf46586a65b9eb461
Gerrit-Change-Number: 24233
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Apr 2026 10:42:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14919: Deflake TestSelfRenameEvent.test self rename event

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24233 )

Change subject: IMPALA-14919: Deflake TestSelfRenameEvent.test_self_rename_event
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a5f3573cce4329e2ff35eaaf46586a65b9eb461
Gerrit-Change-Number: 24233
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Apr 2026 05:54:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14919: Deflake TestSelfRenameEvent.test self rename event

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24233 )

Change subject: IMPALA-14919: Deflake TestSelfRenameEvent.test_self_rename_event
......................................................................

IMPALA-14919: Deflake TestSelfRenameEvent.test_self_rename_event

The test pauses event-processor after executing an ALTER TABLE RENAME
statement, assuming the event will be processed later after that. That's
flaky since the event could actually be processed before the pause
command. Then the first fetch on 'events-skipped' metric happens too
late, e.g., events_skipped_before already counts the first ALTER_TABLE
event.

This patch fixes the issue by fetching the 'events-skipped' metric
before executing the first ALTER TABLE RENAME statement. This ensures
the two ALTER events are processed after that.

Tests:
Ran the test locally 60 times.

Change-Id: I9a5f3573cce4329e2ff35eaaf46586a65b9eb461
Reviewed-on: http://gerrit.cloudera.org:8080/24233
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_event_processing.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a5f3573cce4329e2ff35eaaf46586a65b9eb461
Gerrit-Change-Number: 24233
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-14919: Deflake TestSelfRenameEvent.test self rename event

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24233 )

Change subject: IMPALA-14919: Deflake TestSelfRenameEvent.test_self_rename_event
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22229/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a5f3573cce4329e2ff35eaaf46586a65b9eb461
Gerrit-Change-Number: 24233
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2026 06:21:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14919: Deflake TestSelfRenameEvent.test self rename event

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24233 )

Change subject: IMPALA-14919: Deflake TestSelfRenameEvent.test_self_rename_event
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a5f3573cce4329e2ff35eaaf46586a65b9eb461
Gerrit-Change-Number: 24233
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Apr 2026 05:52:51 +0000
Gerrit-HasComments: No