You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/02/04 19:43:01 UTC

[GitHub] bbende commented on a change in pull request #3288: [WIP] NIFI-5985: Added capability for DBCPConnectionPool to use KerberosCre…

bbende commented on a change in pull request #3288: [WIP] NIFI-5985: Added capability for DBCPConnectionPool to use KerberosCre…
URL: https://github.com/apache/nifi/pull/3288#discussion_r253616346
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
 ##########
 @@ -413,6 +437,15 @@ protected ClassLoader getDriverClassLoader(String locationString, String drvName
      */
     @OnDisabled
     public void shutdown() {
+        try {
 
 Review comment:
   Do we want to still try `dataSource.close()` even when `kerberos.logout()` throws an exception? or maybe we want to reverse these so that it would be the reverse of what we do in @OnEnabled ?
   
   Right now it would bounce out of the method because of the ProcessException. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services