You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2026/08/24 12:28:44 UTC
[Impala-ASF-CR] IMPALA-15285: Deflake test spilling aggs no spilling
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24726
Change subject: IMPALA-15285: Deflake test_spilling_aggs no spilling
......................................................................
IMPALA-15285: Deflake test_spilling_aggs no spilling
There are some backend improvements that reduce the memory usage of
pre-aggregation nodes. test_spilling_aggs expects the query to spill by
setting query option buffer_pool_limit to a small value (30m). But now
it's not always spill. This decreases the query option to a lower value.
Testing
- Ran the test locally
Change-Id: I35d7b7aa6ab45299dd1af06277c650f97bc1b765
---
M testdata/workloads/functional-query/queries/QueryTest/spilling-aggs.test
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/24726/1
--
To view, visit http://gerrit.cloudera.org:8080/24726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35d7b7aa6ab45299dd1af06277c650f97bc1b765
Gerrit-Change-Number: 24726
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-15285: Deflake test spilling aggs no spilling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24726 )
Change subject: IMPALA-15285: Deflake test_spilling_aggs no spilling
......................................................................
IMPALA-15285: Deflake test_spilling_aggs no spilling
There are some backend improvements that reduce the memory usage of
pre-aggregation nodes. test_spilling_aggs expects the query to spill by
setting query option buffer_pool_limit to a small value (30m). But now
it's not always spill. This decreases the query option to a lower value.
Testing
- Ran the test locally
Change-Id: I35d7b7aa6ab45299dd1af06277c650f97bc1b765
Reviewed-on: http://gerrit.cloudera.org:8080/24726
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/spilling-aggs.test
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/24726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I35d7b7aa6ab45299dd1af06277c650f97bc1b765
Gerrit-Change-Number: 24726
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-15285: Deflake test spilling aggs no spilling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24726 )
Change subject: IMPALA-15285: Deflake test_spilling_aggs no spilling
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13914/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I35d7b7aa6ab45299dd1af06277c650f97bc1b765
Gerrit-Change-Number: 24726
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Aug 2026 05:38:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15285: Deflake test spilling aggs no spilling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24726 )
Change subject: IMPALA-15285: Deflake test_spilling_aggs no spilling
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23739/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I35d7b7aa6ab45299dd1af06277c650f97bc1b765
Gerrit-Change-Number: 24726
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 24 Aug 2026 12:50:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15285: Deflake test spilling aggs no spilling
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24726 )
Change subject: IMPALA-15285: Deflake test_spilling_aggs no spilling
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I35d7b7aa6ab45299dd1af06277c650f97bc1b765
Gerrit-Change-Number: 24726
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 24 Aug 2026 13:14:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15285: Deflake test spilling aggs no spilling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24726 )
Change subject: IMPALA-15285: Deflake test_spilling_aggs no spilling
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I35d7b7aa6ab45299dd1af06277c650f97bc1b765
Gerrit-Change-Number: 24726
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Aug 2026 05:38:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15285: Deflake test spilling aggs no spilling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24726 )
Change subject: IMPALA-15285: Deflake test_spilling_aggs no spilling
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I35d7b7aa6ab45299dd1af06277c650f97bc1b765
Gerrit-Change-Number: 24726
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Aug 2026 10:00:30 +0000
Gerrit-HasComments: No