You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/15 10:02:50 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #6120: server: fix NPE when router.service.offering is set due to service/disk offering refactoring
weizhouapache opened a new pull request #6120:
URL: https://github.com/apache/cloudstack/pull/6120
This PR fixes NPE by initializing diskOfferingDao.
```
java.lang.NullPointerException
at org.cloud.network.router.deployment.RouterDeploymentDefinition.verifyServiceOfferingByUuid(RouterDeploymentDefinition.java:411)
at org.cloud.network.router.deployment.RouterDeploymentDefinition.findAccountServiceOfferingId(RouterDeploymentDefinition.java:400)
at org.cloud.network.router.deployment.RouterDeploymentDefinition.findServiceOfferingId(RouterDeploymentDefinition.java:423)
at org.cloud.network.router.deployment.RouterDeploymentDefinition.executeDeployment(RouterDeploymentDefinition.java:378)
at org.cloud.network.router.deployment.RouterDeploymentDefinition.findOrDeployVirtualRouter(RouterDeploymentDefinition.java:242)
at org.cloud.network.router.deployment.RouterDeploymentDefinition.deployVirtualRouter(RouterDeploymentDefinition.java:208)
```
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6120: server: fix NPE when router.service.offering is set due to service/disk offering refactoring
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6120:
URL: https://github.com/apache/cloudstack/pull/6120#issuecomment-1067891981
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6120: server: fix NPE when router.service.offering is set due to service/disk offering refactoring
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6120:
URL: https://github.com/apache/cloudstack/pull/6120#issuecomment-1067892433
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6120: server: fix NPE when router.service.offering is set due to service/disk offering refactoring
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6120:
URL: https://github.com/apache/cloudstack/pull/6120#issuecomment-1067852168
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6120: server: fix NPE when router.service.offering is set due to service/disk offering refactoring
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6120:
URL: https://github.com/apache/cloudstack/pull/6120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6120: server: fix NPE when router.service.offering is set due to service/disk offering refactoring
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6120:
URL: https://github.com/apache/cloudstack/pull/6120#issuecomment-1067791002
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6120: server: fix NPE when router.service.offering is set due to service/disk offering refactoring
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6120:
URL: https://github.com/apache/cloudstack/pull/6120#issuecomment-1067788807
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #6120: server: fix NPE when router.service.offering is set due to service/disk offering refactoring
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #6120:
URL: https://github.com/apache/cloudstack/pull/6120#discussion_r828826126
##########
File path: server/src/main/java/org/apache/cloudstack/network/router/deployment/VpcRouterDeploymentDefinition.java
##########
@@ -14,7 +14,7 @@
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
-package org.cloud.network.router.deployment;
+package org.apache.cloudstack.network.router.deployment;
Review comment:
@nvazquez
in cloudstack codebase, old java classes are in package `com.cloud.xx.xx` , new java classes are in package `org.apache.cloudstack.xx.xx`
these classes are in packages `org.cloud.xx.xx` which are not correct I think. therefore move to `org.apache.cloudstack`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #6120: server: fix NPE when router.service.offering is set due to service/disk offering refactoring
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #6120:
URL: https://github.com/apache/cloudstack/pull/6120#discussion_r828764650
##########
File path: server/src/main/java/org/apache/cloudstack/network/router/deployment/VpcRouterDeploymentDefinition.java
##########
@@ -14,7 +14,7 @@
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
-package org.cloud.network.router.deployment;
+package org.apache.cloudstack.network.router.deployment;
Review comment:
Not blocking question: what's the reason for these package changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6120: server: fix NPE when router.service.offering is set due to service/disk offering refactoring
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6120:
URL: https://github.com/apache/cloudstack/pull/6120#issuecomment-1068474447
<b>Trillian test result (tid-3612)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32377 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6120-t3612-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org