You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/04 23:12:06 UTC
[GitHub] [incubator-nuttx-testing] lulingar opened a new pull request #53: Additions for ESP32
lulingar opened a new pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53
## Summary
Two small changes that I found useful having while setting up a Dockerized environment for testing NuttX on the ESP32 platform.
## Impact
Should cause none.
## Testing
Ran a dockerized build of the esp32-core:nsh configuration and flashed it onto my DevKitC module, worked ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#issuecomment-669215735
@lulingar looks good to me. Thanks for making the CI changes. The build failure is expected since it does not have the new Docker container. I'll merge this in.
I will also update the Jenkins config to pass the correct options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] lulingar commented on a change in pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
lulingar commented on a change in pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#discussion_r465752631
##########
File path: docker/linux/Dockerfile
##########
@@ -183,12 +182,13 @@ ENV PATH="/tools/pinguino-compilers/p32/bin:$PATH"
# RISCV toolchain
COPY --from=nuttx-toolchain-riscv /tools/riscv64-unknown-elf-gcc/ riscv64-unknown-elf-gcc/
ENV PATH="/tools/riscv64-unknown-elf-gcc/bin:$PATH"
-
+
# ESP32 toolchain
COPY --from=nuttx-toolchain-esp32 /tools/xtensa-esp32-elf-gcc/ xtensa-esp32-elf-gcc/
+COPY --from=nuttx-toolchain-esp32 /tools/esp-idf/ esp-idf/
ENV PATH="/tools/xtensa-esp32-elf-gcc/bin:$PATH"
RUN mkdir -p /tools/blobs/esp32core
COPY --from=nuttx-toolchain-esp32 /tools/blobs/* /tools/blobs/esp32core/
RUN pip3 install esptool
-ENTRYPOINT [ "/bin/bash" ]
+CMD [ "/bin/bash" ]
Review comment:
Well, it wasn't. I found a workaround for my use case, so I will revert the github action and the Dockerfile and if needed at some point this topic can be revisited.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#discussion_r465735290
##########
File path: docker/linux/Dockerfile
##########
@@ -183,12 +182,13 @@ ENV PATH="/tools/pinguino-compilers/p32/bin:$PATH"
# RISCV toolchain
COPY --from=nuttx-toolchain-riscv /tools/riscv64-unknown-elf-gcc/ riscv64-unknown-elf-gcc/
ENV PATH="/tools/riscv64-unknown-elf-gcc/bin:$PATH"
-
+
# ESP32 toolchain
COPY --from=nuttx-toolchain-esp32 /tools/xtensa-esp32-elf-gcc/ xtensa-esp32-elf-gcc/
+COPY --from=nuttx-toolchain-esp32 /tools/esp-idf/ esp-idf/
ENV PATH="/tools/xtensa-esp32-elf-gcc/bin:$PATH"
RUN mkdir -p /tools/blobs/esp32core
COPY --from=nuttx-toolchain-esp32 /tools/blobs/* /tools/blobs/esp32core/
RUN pip3 install esptool
-ENTRYPOINT [ "/bin/bash" ]
+CMD [ "/bin/bash" ]
Review comment:
I agree that it is odd. I'm not sure why we used entrypoint in the first place. Happy to have it corrected so CMD can be used, we just need to also update this
https://www.github.com/apache/incubator-nuttx-testing/tree/master/.github%2Factions%2Fci-container%2Faction.yaml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] lulingar commented on a change in pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
lulingar commented on a change in pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#discussion_r465748585
##########
File path: docker/linux/Dockerfile
##########
@@ -183,12 +182,13 @@ ENV PATH="/tools/pinguino-compilers/p32/bin:$PATH"
# RISCV toolchain
COPY --from=nuttx-toolchain-riscv /tools/riscv64-unknown-elf-gcc/ riscv64-unknown-elf-gcc/
ENV PATH="/tools/riscv64-unknown-elf-gcc/bin:$PATH"
-
+
# ESP32 toolchain
COPY --from=nuttx-toolchain-esp32 /tools/xtensa-esp32-elf-gcc/ xtensa-esp32-elf-gcc/
+COPY --from=nuttx-toolchain-esp32 /tools/esp-idf/ esp-idf/
ENV PATH="/tools/xtensa-esp32-elf-gcc/bin:$PATH"
RUN mkdir -p /tools/blobs/esp32core
COPY --from=nuttx-toolchain-esp32 /tools/blobs/* /tools/blobs/esp32core/
RUN pip3 install esptool
-ENTRYPOINT [ "/bin/bash" ]
+CMD [ "/bin/bash" ]
Review comment:
I have added a commit for this. Let's see if it's good enough...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] acassis edited a comment on pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#issuecomment-669164880
Guys, just an observation that Espressif guys told me: "QEMU version has somewhat of a broken DIO support now."
So, this modification will prevent us to test our code on QEMU, I don't think it is a big issue, but could be if we decide to use some automated tests using QEMU.
See: https://github.com/espressif/qemu/wiki#build-test-app
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#discussion_r465443263
##########
File path: docker/linux/Dockerfile
##########
@@ -183,12 +182,13 @@ ENV PATH="/tools/pinguino-compilers/p32/bin:$PATH"
# RISCV toolchain
COPY --from=nuttx-toolchain-riscv /tools/riscv64-unknown-elf-gcc/ riscv64-unknown-elf-gcc/
ENV PATH="/tools/riscv64-unknown-elf-gcc/bin:$PATH"
-
+
# ESP32 toolchain
COPY --from=nuttx-toolchain-esp32 /tools/xtensa-esp32-elf-gcc/ xtensa-esp32-elf-gcc/
+COPY --from=nuttx-toolchain-esp32 /tools/esp-idf/ esp-idf/
ENV PATH="/tools/xtensa-esp32-elf-gcc/bin:$PATH"
RUN mkdir -p /tools/blobs/esp32core
COPY --from=nuttx-toolchain-esp32 /tools/blobs/* /tools/blobs/esp32core/
RUN pip3 install esptool
-ENTRYPOINT [ "/bin/bash" ]
+CMD [ "/bin/bash" ]
Review comment:
Why are we changing this? I think this will break the CI systems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] acassis commented on pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#issuecomment-669164880
Guys, just an observation that Espressif guys told me: "QEMU version has somewhat of a broken DIO support now."
So, this modification will prevent us to test our code on QEMU, I don't think it is a big issue, but could be if we decide to some automated tests using QEMU.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#discussion_r465588963
##########
File path: docker/linux/Dockerfile
##########
@@ -183,12 +182,13 @@ ENV PATH="/tools/pinguino-compilers/p32/bin:$PATH"
# RISCV toolchain
COPY --from=nuttx-toolchain-riscv /tools/riscv64-unknown-elf-gcc/ riscv64-unknown-elf-gcc/
ENV PATH="/tools/riscv64-unknown-elf-gcc/bin:$PATH"
-
+
# ESP32 toolchain
COPY --from=nuttx-toolchain-esp32 /tools/xtensa-esp32-elf-gcc/ xtensa-esp32-elf-gcc/
+COPY --from=nuttx-toolchain-esp32 /tools/esp-idf/ esp-idf/
ENV PATH="/tools/xtensa-esp32-elf-gcc/bin:$PATH"
RUN mkdir -p /tools/blobs/esp32core
COPY --from=nuttx-toolchain-esp32 /tools/blobs/* /tools/blobs/esp32core/
RUN pip3 install esptool
-ENTRYPOINT [ "/bin/bash" ]
+CMD [ "/bin/bash" ]
Review comment:
you can always override it with --entrypoint.
on the other hand, the ENTRYPOINT usage here looks a bit unusual for me.
@btashton can you explain why it's done this way? i guess the ci can specify bash, rather than just "-c".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] lulingar commented on a change in pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
lulingar commented on a change in pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#discussion_r465577050
##########
File path: docker/linux/Dockerfile
##########
@@ -183,12 +182,13 @@ ENV PATH="/tools/pinguino-compilers/p32/bin:$PATH"
# RISCV toolchain
COPY --from=nuttx-toolchain-riscv /tools/riscv64-unknown-elf-gcc/ riscv64-unknown-elf-gcc/
ENV PATH="/tools/riscv64-unknown-elf-gcc/bin:$PATH"
-
+
# ESP32 toolchain
COPY --from=nuttx-toolchain-esp32 /tools/xtensa-esp32-elf-gcc/ xtensa-esp32-elf-gcc/
+COPY --from=nuttx-toolchain-esp32 /tools/esp-idf/ esp-idf/
ENV PATH="/tools/xtensa-esp32-elf-gcc/bin:$PATH"
RUN mkdir -p /tools/blobs/esp32core
COPY --from=nuttx-toolchain-esp32 /tools/blobs/* /tools/blobs/esp32core/
RUN pip3 install esptool
-ENTRYPOINT [ "/bin/bash" ]
+CMD [ "/bin/bash" ]
Review comment:
I found an issue when trying to do `docker run .... /bin/bash`, as I mentioned in the relevant commit message. My use case for doing that was piping bash scripts into the `docker run` command. Let me know if this definitely cannot be accomodated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#issuecomment-668946879
LGTM, @btashton do you have any concern?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#discussion_r465757317
##########
File path: docker/linux/Dockerfile
##########
@@ -183,12 +182,13 @@ ENV PATH="/tools/pinguino-compilers/p32/bin:$PATH"
# RISCV toolchain
COPY --from=nuttx-toolchain-riscv /tools/riscv64-unknown-elf-gcc/ riscv64-unknown-elf-gcc/
ENV PATH="/tools/riscv64-unknown-elf-gcc/bin:$PATH"
-
+
# ESP32 toolchain
COPY --from=nuttx-toolchain-esp32 /tools/xtensa-esp32-elf-gcc/ xtensa-esp32-elf-gcc/
+COPY --from=nuttx-toolchain-esp32 /tools/esp-idf/ esp-idf/
ENV PATH="/tools/xtensa-esp32-elf-gcc/bin:$PATH"
RUN mkdir -p /tools/blobs/esp32core
COPY --from=nuttx-toolchain-esp32 /tools/blobs/* /tools/blobs/esp32core/
RUN pip3 install esptool
-ENTRYPOINT [ "/bin/bash" ]
+CMD [ "/bin/bash" ]
Review comment:
I just merged it. The issue here is that the CI is brittle and won't use the new container because it has not been published. That only happens once it has been merged in. We can revert that commit if the master build fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton merged pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] lulingar commented on pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
lulingar commented on pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#issuecomment-669189327
Thank you @acassis for the heads up. I have pushed a provision to restore the previous behavior of this Dockerfile but enables disabling the DOUT mode via a Docker `ARG`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#discussion_r465443263
##########
File path: docker/linux/Dockerfile
##########
@@ -183,12 +182,13 @@ ENV PATH="/tools/pinguino-compilers/p32/bin:$PATH"
# RISCV toolchain
COPY --from=nuttx-toolchain-riscv /tools/riscv64-unknown-elf-gcc/ riscv64-unknown-elf-gcc/
ENV PATH="/tools/riscv64-unknown-elf-gcc/bin:$PATH"
-
+
# ESP32 toolchain
COPY --from=nuttx-toolchain-esp32 /tools/xtensa-esp32-elf-gcc/ xtensa-esp32-elf-gcc/
+COPY --from=nuttx-toolchain-esp32 /tools/esp-idf/ esp-idf/
ENV PATH="/tools/xtensa-esp32-elf-gcc/bin:$PATH"
RUN mkdir -p /tools/blobs/esp32core
COPY --from=nuttx-toolchain-esp32 /tools/blobs/* /tools/blobs/esp32core/
RUN pip3 install esptool
-ENTRYPOINT [ "/bin/bash" ]
+CMD [ "/bin/bash" ]
Review comment:
Why are we changing this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] lulingar commented on a change in pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
lulingar commented on a change in pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#discussion_r465759340
##########
File path: docker/linux/Dockerfile
##########
@@ -183,12 +182,13 @@ ENV PATH="/tools/pinguino-compilers/p32/bin:$PATH"
# RISCV toolchain
COPY --from=nuttx-toolchain-riscv /tools/riscv64-unknown-elf-gcc/ riscv64-unknown-elf-gcc/
ENV PATH="/tools/riscv64-unknown-elf-gcc/bin:$PATH"
-
+
# ESP32 toolchain
COPY --from=nuttx-toolchain-esp32 /tools/xtensa-esp32-elf-gcc/ xtensa-esp32-elf-gcc/
+COPY --from=nuttx-toolchain-esp32 /tools/esp-idf/ esp-idf/
ENV PATH="/tools/xtensa-esp32-elf-gcc/bin:$PATH"
RUN mkdir -p /tools/blobs/esp32core
COPY --from=nuttx-toolchain-esp32 /tools/blobs/* /tools/blobs/esp32core/
RUN pip3 install esptool
-ENTRYPOINT [ "/bin/bash" ]
+CMD [ "/bin/bash" ]
Review comment:
That's good, thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] acassis edited a comment on pull request #53: Additions for ESP32
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #53:
URL: https://github.com/apache/incubator-nuttx-testing/pull/53#issuecomment-669164880
Guys, just an observation that Espressif guys told me: "QEMU version has somewhat of a broken DIO support now."
So, this modification will prevent us to test our code on QEMU, I don't think it is a big issue, but could be if we decide to use some automated tests using QEMU.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org