You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/10 12:27:05 UTC
[GitHub] [arrow] pitrou commented on a change in pull request #7784: ARROW-9402: [C++] Rework portable wrappers for checked integer arithmetic
pitrou commented on a change in pull request #7784:
URL: https://github.com/apache/arrow/pull/7784#discussion_r467867983
##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##########
@@ -72,35 +77,19 @@ struct Add {
};
struct AddChecked {
-#if __has_builtin(__builtin_add_overflow)
- template <typename T>
- static enable_if_integer<T> Call(KernelContext* ctx, T left, T right) {
+ template <typename T, typename Arg0, typename Arg1>
+ enable_if_integer<T> Call(KernelContext* ctx, Arg0 left, Arg1 right) {
+ static_assert(std::is_same<T, Arg0>::value && std::is_same<T, Arg1>::value, "");
T result;
- if (ARROW_PREDICT_FALSE(__builtin_add_overflow(left, right, &result))) {
+ if (ARROW_PREDICT_FALSE(AddWithOverflow(left, right, &result))) {
ctx->SetStatus(Status::Invalid("overflow"));
}
return result;
}
-#else
- template <typename T>
- static enable_if_unsigned_integer<T> Call(KernelContext* ctx, T left, T right) {
- if (ARROW_PREDICT_FALSE(arrow::internal::HasPositiveAdditionOverflow(left, right))) {
- ctx->SetStatus(Status::Invalid("overflow"));
- }
- return left + right;
- }
-
- template <typename T>
- static enable_if_signed_integer<T> Call(KernelContext* ctx, T left, T right) {
- if (ARROW_PREDICT_FALSE(arrow::internal::HasSignedAdditionOverflow(left, right))) {
- ctx->SetStatus(Status::Invalid("overflow"));
- }
- return left + right;
- }
-#endif
- template <typename T>
- static constexpr enable_if_floating_point<T> Call(KernelContext*, T left, T right) {
+ template <typename T, typename Arg0, typename Arg1>
+ enable_if_floating_point<T> Call(KernelContext*, Arg0 left, Arg1 right) {
+ static_assert(std::is_same<T, Arg0>::value && std::is_same<T, Arg1>::value, "");
Review comment:
It doesn't compile, because `Call` is invoked with explicit template arguments by the kernel execution machinery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org