You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "itiels (via GitHub)" <gi...@apache.org> on 2023/10/30 14:41:19 UTC

Re: [PR] [CALCITE-5863] incorrect validation for window with range and multiple order by [calcite]

itiels commented on code in PR #3325:
URL: https://github.com/apache/calcite/pull/3325#discussion_r1376334494


##########
core/src/main/java/org/apache/calcite/sql/SqlWindow.java:
##########
@@ -610,8 +610,10 @@ public boolean isAllowPartial() {
       if (orderList.size() > 0) {
         // if order by is a compound list then range not allowed
         if (orderList.size() > 1 && !isRows()) {
-          throw validator.newValidationError(isRows,
-              RESOURCE.compoundOrderByProhibitsRange());
+          if (!onlyLiteralBounds(lowerBound, upperBound)) {

Review Comment:
   Added test case



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org