You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Vamsavardhana Reddy (JIRA)" <de...@geronimo.apache.org> on 2006/09/27 15:07:52 UTC

[jira] Created: (GERONIMO-2436) FileKeystoreInstance.generateKeyPair() should check if the keystore is loaded

FileKeystoreInstance.generateKeyPair() should check if the keystore is loaded
-----------------------------------------------------------------------------

                 Key: GERONIMO-2436
                 URL: http://issues.apache.org/jira/browse/GERONIMO-2436
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: security
    Affects Versions: 1.1.1, 1.2
            Reporter: Vamsavardhana Reddy
             Fix For: 1.1.2, 1.2


I have the following code:

KeystoreInstance ks = PortletManager.getCurrentServer(request).getKeystoreManager().createKeystore("mykeystore", password);
ks.unlockKeystore(password);
ks.generateKeyPair(alias, password, password, keyAlgorithm, keySize, algorithm, 365, cn, ou, o, l, st, c);

The generateKeyPair() call is resulting in NullPointerException since the newly created keystore is not readily loaded and generateKeyPair() is not checking if the keystore is loaded. generateKeyPair() should check and load the keystore if necessary.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (GERONIMO-2436) FileKeystoreInstance.generateKeyPair() should check if the keystore is loaded

Posted by "Vamsavardhana Reddy (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-2436?page=all ]

Vamsavardhana Reddy updated GERONIMO-2436:
------------------------------------------

    Attachment: GERONIMO-2436-v1.1.x.patch

GERONIMO-2436-v1.1.x.patch: For branches 1.1

> FileKeystoreInstance.generateKeyPair() should check if the keystore is loaded
> -----------------------------------------------------------------------------
>
>                 Key: GERONIMO-2436
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2436
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: security
>    Affects Versions: 1.2, 1.1.1
>            Reporter: Vamsavardhana Reddy
>             Fix For: 1.2, 1.1.2
>
>         Attachments: GERONIMO-2436-v1.1.x.patch, GERONIMO-2436-v1.2.patch
>
>
> I have the following code:
> KeystoreInstance ks = PortletManager.getCurrentServer(request).getKeystoreManager().createKeystore("mykeystore", password);
> ks.unlockKeystore(password);
> ks.generateKeyPair(alias, password, password, keyAlgorithm, keySize, algorithm, 365, cn, ou, o, l, st, c);
> The generateKeyPair() call is resulting in NullPointerException since the newly created keystore is not readily loaded and generateKeyPair() is not checking if the keystore is loaded. generateKeyPair() should check and load the keystore if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (GERONIMO-2436) FileKeystoreInstance.generateKeyPair() should check if the keystore is loaded

Posted by "Donald Woods (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-2436?page=comments#action_12439650 ] 
            
Donald Woods commented on GERONIMO-2436:
----------------------------------------

The third line that is added in GERONIMO-2436-v1.1.x.patch should be:
+                return false;
instead of
+                return null;
The 1.2 version of the patch is correct.


> FileKeystoreInstance.generateKeyPair() should check if the keystore is loaded
> -----------------------------------------------------------------------------
>
>                 Key: GERONIMO-2436
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2436
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: security
>    Affects Versions: 1.2, 1.1.1
>            Reporter: Vamsavardhana Reddy
>             Fix For: 1.2, 1.1.2
>
>         Attachments: GERONIMO-2436-v1.1.x.patch, GERONIMO-2436-v1.2.patch
>
>
> I have the following code:
> KeystoreInstance ks = PortletManager.getCurrentServer(request).getKeystoreManager().createKeystore("mykeystore", password);
> ks.unlockKeystore(password);
> ks.generateKeyPair(alias, password, password, keyAlgorithm, keySize, algorithm, 365, cn, ou, o, l, st, c);
> The generateKeyPair() call is resulting in NullPointerException since the newly created keystore is not readily loaded and generateKeyPair() is not checking if the keystore is loaded. generateKeyPair() should check and load the keystore if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (GERONIMO-2436) FileKeystoreInstance.generateKeyPair() should check if the keystore is loaded

Posted by "Vamsavardhana Reddy (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-2436?page=all ]

Vamsavardhana Reddy updated GERONIMO-2436:
------------------------------------------

    Attachment: GERONIMO-2436-v1.2.patch

GERONIMO-2436-v1.2.patch: Adds a check to generateKeyPair() to load keystore if necessary.

> FileKeystoreInstance.generateKeyPair() should check if the keystore is loaded
> -----------------------------------------------------------------------------
>
>                 Key: GERONIMO-2436
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2436
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: security
>    Affects Versions: 1.2, 1.1.1
>            Reporter: Vamsavardhana Reddy
>             Fix For: 1.2, 1.1.2
>
>         Attachments: GERONIMO-2436-v1.2.patch
>
>
> I have the following code:
> KeystoreInstance ks = PortletManager.getCurrentServer(request).getKeystoreManager().createKeystore("mykeystore", password);
> ks.unlockKeystore(password);
> ks.generateKeyPair(alias, password, password, keyAlgorithm, keySize, algorithm, 365, cn, ou, o, l, st, c);
> The generateKeyPair() call is resulting in NullPointerException since the newly created keystore is not readily loaded and generateKeyPair() is not checking if the keystore is loaded. generateKeyPair() should check and load the keystore if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (GERONIMO-2436) FileKeystoreInstance.generateKeyPair() should check if the keystore is loaded

Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-2436?page=all ]

Vamsavardhana Reddy closed GERONIMO-2436.
-----------------------------------------

    Resolution: Fixed

Fixed. Rev 470482 (branches\1.1)

> FileKeystoreInstance.generateKeyPair() should check if the keystore is loaded
> -----------------------------------------------------------------------------
>
>                 Key: GERONIMO-2436
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2436
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: security
>    Affects Versions: 1.1.1, 1.2
>            Reporter: Vamsavardhana Reddy
>             Fix For: 1.1.2, 1.2
>
>         Attachments: GERONIMO-2436-v1.1.x-correctone.patch, GERONIMO-2436-v1.1.x.patch, GERONIMO-2436-v1.2.patch
>
>
> I have the following code:
> KeystoreInstance ks = PortletManager.getCurrentServer(request).getKeystoreManager().createKeystore("mykeystore", password);
> ks.unlockKeystore(password);
> ks.generateKeyPair(alias, password, password, keyAlgorithm, keySize, algorithm, 365, cn, ou, o, l, st, c);
> The generateKeyPair() call is resulting in NullPointerException since the newly created keystore is not readily loaded and generateKeyPair() is not checking if the keystore is loaded. generateKeyPair() should check and load the keystore if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (GERONIMO-2436) FileKeystoreInstance.generateKeyPair() should check if the keystore is loaded

Posted by "Vamsavardhana Reddy (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-2436?page=all ]

Vamsavardhana Reddy updated GERONIMO-2436:
------------------------------------------

    Attachment: GERONIMO-2436-v1.1.x-correctone.patch

That didn't cook well.  Thanks Donald for catching it.

Ignore GERONIMO-2436-v1.1.x.patch and use GERONIMO-2436-v1.1.x-correctone.patch

> FileKeystoreInstance.generateKeyPair() should check if the keystore is loaded
> -----------------------------------------------------------------------------
>
>                 Key: GERONIMO-2436
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2436
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: security
>    Affects Versions: 1.2, 1.1.1
>            Reporter: Vamsavardhana Reddy
>             Fix For: 1.2, 1.1.2
>
>         Attachments: GERONIMO-2436-v1.1.x-correctone.patch, GERONIMO-2436-v1.1.x.patch, GERONIMO-2436-v1.2.patch
>
>
> I have the following code:
> KeystoreInstance ks = PortletManager.getCurrentServer(request).getKeystoreManager().createKeystore("mykeystore", password);
> ks.unlockKeystore(password);
> ks.generateKeyPair(alias, password, password, keyAlgorithm, keySize, algorithm, 365, cn, ou, o, l, st, c);
> The generateKeyPair() call is resulting in NullPointerException since the newly created keystore is not readily loaded and generateKeyPair() is not checking if the keystore is loaded. generateKeyPair() should check and load the keystore if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (GERONIMO-2436) FileKeystoreInstance.generateKeyPair() should check if the keystore is loaded

Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-2436?page=comments#action_12446700 ] 
            
Vamsavardhana Reddy commented on GERONIMO-2436:
-----------------------------------------------

Fixed in trunk as part of GERONIMO-2504.

> FileKeystoreInstance.generateKeyPair() should check if the keystore is loaded
> -----------------------------------------------------------------------------
>
>                 Key: GERONIMO-2436
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2436
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: security
>    Affects Versions: 1.1.1, 1.2
>            Reporter: Vamsavardhana Reddy
>             Fix For: 1.1.2, 1.2
>
>         Attachments: GERONIMO-2436-v1.1.x-correctone.patch, GERONIMO-2436-v1.1.x.patch, GERONIMO-2436-v1.2.patch
>
>
> I have the following code:
> KeystoreInstance ks = PortletManager.getCurrentServer(request).getKeystoreManager().createKeystore("mykeystore", password);
> ks.unlockKeystore(password);
> ks.generateKeyPair(alias, password, password, keyAlgorithm, keySize, algorithm, 365, cn, ou, o, l, st, c);
> The generateKeyPair() call is resulting in NullPointerException since the newly created keystore is not readily loaded and generateKeyPair() is not checking if the keystore is loaded. generateKeyPair() should check and load the keystore if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira