You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2016/03/03 11:33:11 UTC
[Bug 59106] New: WorkdayFunction does not read correctly the area
with holidays to calculate work days
https://bz.apache.org/bugzilla/show_bug.cgi?id=59106
Bug ID: 59106
Summary: WorkdayFunction does not read correctly the area with
holidays to calculate work days
Product: POI
Version: 3.13-FINAL
Hardware: PC
Status: NEW
Severity: critical
Priority: P2
Component: XSSF
Assignee: dev@poi.apache.org
Reporter: bondaraw@gmail.com
Created attachment 33618
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33618&action=edit
Excel file with data for testing and Unit test
Package: org.apache.poi.ss.formula.atp
Class: ArgumentsEvaluator
Method: evaluateDatesArg(ValueEval arg, int srcCellRow, int srcCellCol);
Here is the code:
for (int i = area.getFirstRow(); i <= area.getLastRow(); i++) {
for (int j = area.getFirstColumn(); j <= area.getLastColumn(); j++) {
valuesList.add(evaluateDateArg(area.getValue(i, j), i, j));
}
}
i and j stored absolute path.
Method getValue() used relative path. Here is code:
public final ValueEval getValue(int row, int col) {
return getRelativeValue(row, col);
}
WorkdayFunction does not read correctly the area with holidays to calculate
work days. We have debugged it and found that you are using a relating path
(area.getValue()), but you need to use an absolute path
(area.getAbsoluteValue()).
An excel file with data for testing and Unit test is attached.
Please fix it.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59106] WorkdayFunction does not read correctly the area with
holidays to calculate work days
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59106
--- Comment #3 from Artem Bondar <bo...@gmail.com> ---
Created attachment 33662
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33662&action=edit
Excel document with tests data
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59106] [PATCH] WorkdayFunction does not read correctly the area
with holidays to calculate work days
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59106
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59106] [PATCH] WorkdayFunction does not read correctly the area
with holidays to calculate work days
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59106
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #4 from Dominik Stadler <do...@gmx.at> ---
Applied in r1753125, thanks for the patch!
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59106] WorkdayFunction does not read correctly the area with
holidays to calculate work days
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59106
Artem Bondar <bo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #33618|0 |1
is obsolete| |
--- Comment #1 from Artem Bondar <bo...@gmail.com> ---
Created attachment 33660
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33660&action=edit
Patch file
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59106] [PATCH] WorkdayFunction does not read correctly the area
with holidays to calculate work days
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59106
Artem Bondar <bo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|WorkdayFunction does not |[PATCH] WorkdayFunction
|read correctly the area |does not read correctly the
|with holidays to calculate |area with holidays to
|work days |calculate work days
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59106] WorkdayFunction does not read correctly the area with
holidays to calculate work days
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59106
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59106] [PATCH] WorkdayFunction does not read correctly the area
with holidays to calculate work days
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59106
Artem Bondar <bo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bondaraw@gmail.com
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59106] WorkdayFunction does not read correctly the area with
holidays to calculate work days
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59106
--- Comment #2 from Artem Bondar <bo...@gmail.com> ---
Created attachment 33661
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33661&action=edit
Unit test
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org