[GitHub] [echarts] Ovilia commented on a diff in pull request #17311: fix(axis): fix time axis labels and ticks being overlapped

[GitBox <gi...@apache.org>]

Ovilia commented on code in PR #17311:
URL: https://github.com/apache/echarts/pull/17311#discussion_r1029977152


##########
src/coord/Axis.ts:
##########
@@ -221,7 +221,8 @@ class Axis {
     }
 
     getViewLabels(): ReturnType<typeof createAxisLabels>['labels'] {
-        return createAxisLabels(this).labels;
+        const labels = createAxisLabels(this).labels;

Review Comment:
   This change should be reverted in later commits.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org