You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/14 21:32:58 UTC

[jira] [Commented] (GEODE-2188) ExampleSecurityManager references SampleSecurityManager in javadoc

    [ https://issues.apache.org/jira/browse/GEODE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749548#comment-15749548 ] 

ASF GitHub Bot commented on GEODE-2188:
---------------------------------------

GitHub user kjduling opened a pull request:

    https://github.com/apache/geode/pull/316

    GEODE-2188: ExampleSecurityManager references SampleSecurityManager i…

    …n javadoc
    
    This corrects some output messages and javadoc entries after the ExampleSecurityManager was moved.  It also points the old SampleSecurityManagerTest at ExampleSecurityManager.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kjduling/apache-geode feature/GEODE-2188

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/316.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #316
    
----
commit 135c2c7d268f1b985fc07bac855bc4c2df680281
Author: Kevin J. Duling <kd...@pivotal.io>
Date:   2016-12-14T21:23:19Z

    GEODE-2188: ExampleSecurityManager references SampleSecurityManager in javadoc

----


> ExampleSecurityManager references SampleSecurityManager in javadoc
> ------------------------------------------------------------------
>
>                 Key: GEODE-2188
>                 URL: https://issues.apache.org/jira/browse/GEODE-2188
>             Project: Geode
>          Issue Type: Bug
>          Components: core, docs
>            Reporter: Kevin Duling
>            Assignee: Kevin Duling
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> Example code was moved in GEODE-2092, but some strings need to be updated.
> Javadoc references an incorrect path.
> {{@code security-manager = org.apache.geode.security.examples.SampleSecurityManager}}
> and several strings refer to SampleSecurityManager.
> E.g., 
> {code}
>     if (!initializeFromJsonResource(jsonPropertyValue)) {
>       throw new AuthenticationFailedException(
>           "SampleSecurityManager: unable to find json resource \"" + jsonPropertyValue
>               + "\" as specified by [" + SECURITY_JSON + "].");
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)