You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/04/14 15:27:49 UTC

[GitHub] [trafficcontrol] jrushford edited a comment on pull request #5741: Inject header rw for request header max size

jrushford edited a comment on pull request #5741:
URL: https://github.com/apache/trafficcontrol/pull/5741#issuecomment-819606294


   > @jrushford Definitely. It should also run on `traffic_ops/vx-client` and `traffic_ops/toclientlib` changes, if it doesn't
   
   @jpappa200 Ok so have a look at .github/workflows/traffic-ops-ort-tests.yml, see 'paths` in the workflow_dispatch and pull_request paths.  It looks like 'traffic_ops/vx-client` is done with this pattern 'traffic_ops/*client/**.go' but the other two should be added:
   
   `'traffic_ops/toclientlib/**.go' and lib/atscfg-go/**.go.`
   
   When you push changes you can verify by going to the GitHub.com, select your request_header branch then hit 'actions' and drill into the "Traffic Ops ORT integration tests" workflow and verify the test jobs all run successfully.  There are 4 jobs, traffic_ops, traffic_ops_ort, trafficserver, and finally ORT_tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org