You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Adrian Cumiskey (Created) (JIRA)" <ji...@apache.org> on 2011/11/03 07:41:32 UTC
[jira] [Created] (OGNL-37) [PATCH] Findbugs fixes
[PATCH] Findbugs fixes
----------------------
Key: OGNL-37
URL: https://issues.apache.org/jira/browse/OGNL-37
Project: OGNL
Issue Type: Improvement
Reporter: Adrian Cumiskey
Priority: Minor
ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override PropertyDescriptor.
ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String).
ASTMethod: Use StringBuilder instead of String concatenation with '+'.
DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class fields.
OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements.
ASTChain: Remove int boxing, lets rely on autoboxing.
ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary conditional checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
Posted by "Adrian Cumiskey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143051#comment-13143051 ]
Adrian Cumiskey commented on OGNL-37:
-------------------------------------
Its actually worse, the reason ConcurrentModificationException never happened in the previous revision was because the map.remove( value ) operation always requires a key of type String to have a possibility to remove the Entry. It was completely redundant code that would never have possibilty to mutate the map. Thanks again for the swift processing of my patch.
> [PATCH] Findbugs fixes
> ----------------------
>
> Key: OGNL-37
> URL: https://issues.apache.org/jira/browse/OGNL-37
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Assignee: Maurizio Cucchiara
> Priority: Minor
> Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class fields.
> OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary conditional checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
Posted by "Maurizio Cucchiara (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143018#comment-13143018 ]
Maurizio Cucchiara commented on OGNL-37:
----------------------------------------
Once again, thank you Adrian.
I applied your patch with a little exception:
what was
{quote}
ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String).
{quote}
has become
{quote}
ExpressionCompiler: Corrected attempt to remove LocalReference (keys was always of type String).
{quote}
In fact that was the original behavior of ExpressionCompiler (see at row [699|http://svn.apache.org/viewvc/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java?r1=1187867&r2=1197034&pathrev=1197034&diff_format=h]).
Don't you agree?
> [PATCH] Findbugs fixes
> ----------------------
>
> Key: OGNL-37
> URL: https://issues.apache.org/jira/browse/OGNL-37
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class fields.
> OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary conditional checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142990#comment-13142990 ]
Hudson commented on OGNL-37:
----------------------------
Integrated in ognl #180 (See [https://builds.apache.org/job/ognl/180/])
OGNL-37 - Provide equals() and hashcode() implementation to override PropertyDescriptor.
OGNL-37 - Use StringBuilder instead of String concatenation with '+'.
OGNL-37 - Use StringBuilder instead of String concatenation with '+'.
OGNL-37 - Replaced for loops with foreach version.
OGNL-37 - Remove int boxing, lets rely on autoboxing.
OGNL-37 - Remove unnecessary int boxing and redundant code.
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197018
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ObjectIndexedPropertyDescriptor.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197015
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ExpressionNode.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197014
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197011
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197009
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197007
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ArrayPropertyAccessor.java
> [PATCH] Findbugs fixes
> ----------------------
>
> Key: OGNL-37
> URL: https://issues.apache.org/jira/browse/OGNL-37
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class fields.
> OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary conditional checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
Posted by "Maurizio Cucchiara (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143023#comment-13143023 ]
Maurizio Cucchiara commented on OGNL-37:
----------------------------------------
Ignore my last message, I have almost forgotten about {{ConcurrentModificationException}}
> [PATCH] Findbugs fixes
> ----------------------
>
> Key: OGNL-37
> URL: https://issues.apache.org/jira/browse/OGNL-37
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Assignee: Maurizio Cucchiara
> Priority: Minor
> Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class fields.
> OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary conditional checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OGNL-37) [PATCH] Findbugs fixes
Posted by "Adrian Cumiskey (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cumiskey updated OGNL-37:
--------------------------------
Attachment: patch-OGNL37.txt
> [PATCH] Findbugs fixes
> ----------------------
>
> Key: OGNL-37
> URL: https://issues.apache.org/jira/browse/OGNL-37
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class fields.
> OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary conditional checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143843#comment-13143843 ]
Hudson commented on OGNL-37:
----------------------------
Integrated in ognl #183 (See [https://builds.apache.org/job/ognl/183/])
Added OGNL-37 to the change list
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197432
Files :
* /commons/proper/ognl/trunk/src/changes/changes.xml
> [PATCH] Findbugs fixes
> ----------------------
>
> Key: OGNL-37
> URL: https://issues.apache.org/jira/browse/OGNL-37
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Assignee: Maurizio Cucchiara
> Priority: Minor
> Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class fields.
> OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary conditional checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143034#comment-13143034 ]
Hudson commented on OGNL-37:
----------------------------
Integrated in ognl #182 (See [https://builds.apache.org/job/ognl/182/])
OGNL-37 - Avoid concurrentModificationException
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197043
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java
> [PATCH] Findbugs fixes
> ----------------------
>
> Key: OGNL-37
> URL: https://issues.apache.org/jira/browse/OGNL-37
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Assignee: Maurizio Cucchiara
> Priority: Minor
> Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class fields.
> OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary conditional checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OGNL-37) [PATCH] Findbugs fixes
Posted by "Maurizio Cucchiara (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maurizio Cucchiara resolved OGNL-37.
------------------------------------
Resolution: Fixed
Assignee: Maurizio Cucchiara
> [PATCH] Findbugs fixes
> ----------------------
>
> Key: OGNL-37
> URL: https://issues.apache.org/jira/browse/OGNL-37
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Assignee: Maurizio Cucchiara
> Priority: Minor
> Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class fields.
> OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary conditional checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143012#comment-13143012 ]
Hudson commented on OGNL-37:
----------------------------
Integrated in ognl #181 (See [https://builds.apache.org/job/ognl/181/])
OGNL-37 - Corrected attempt to remove LocalReference (keys was always of type String).
OGNL-37 - Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements.
OGNL-37 - use valueOf() instead of new for boxing. Adjust unnecessary conditional checking.
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197034
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197024
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197020
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlOps.java
> [PATCH] Findbugs fixes
> ----------------------
>
> Key: OGNL-37
> URL: https://issues.apache.org/jira/browse/OGNL-37
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class fields.
> OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary conditional checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142969#comment-13142969 ]
Hudson commented on OGNL-37:
----------------------------
Integrated in ognl #179 (See [https://builds.apache.org/job/ognl/179/])
OGNL-37 - Modified equals() implementation to take account of super class fields.
OGNL-37 - Use Map.entrySet instead of Map.keySet for better performance.
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197002
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/DeclaredMethodCacheEntry.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1196996
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlContext.java
> [PATCH] Findbugs fixes
> ----------------------
>
> Key: OGNL-37
> URL: https://issues.apache.org/jira/browse/OGNL-37
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class fields.
> OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary conditional checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira