You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/09/23 22:38:30 UTC
Review Request 25953: Allow optional initial and desired states.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25953/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-741
https://issues.apache.org/jira/browse/AURORA-741
Repository: aurora
Description
-------
Added safety checks around initial/desired state presence and converted to left outer joins.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 361d3b8c0d59a0dad6b00c8a4b78ec8284383586
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 80535432c2c45eb2f3eb3bea4a797a99ea4fc2c9
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java aa7feb916f879f60d46ebaf53e47ba30d861c7fa
Diff: https://reviews.apache.org/r/25953/diff/
Testing
-------
gradle -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 25953: Allow optional initial and desired states.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Sept. 23, 2014, 8:48 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java, line 87
> > <https://reviews.apache.org/r/25953/diff/1/?file=703165#file703165line87>
> >
> > You should include a precondition check for desiredState being set or initialState being non-empty.
Sure, added.
> On Sept. 23, 2014, 8:48 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java, line 103
> > <https://reviews.apache.org/r/25953/diff/1/?file=703165#file703165line103>
> >
> > !isEmpty()
Done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25953/#review54328
-----------------------------------------------------------
On Sept. 23, 2014, 8:38 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25953/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2014, 8:38 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-741
> https://issues.apache.org/jira/browse/AURORA-741
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added safety checks around initial/desired state presence and converted to left outer joins.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 361d3b8c0d59a0dad6b00c8a4b78ec8284383586
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 80535432c2c45eb2f3eb3bea4a797a99ea4fc2c9
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java aa7feb916f879f60d46ebaf53e47ba30d861c7fa
>
> Diff: https://reviews.apache.org/r/25953/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25953: Allow optional initial and desired states.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25953/#review54328
-----------------------------------------------------------
Ship it!
LGTM with a few minor changes.
src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java
<https://reviews.apache.org/r/25953/#comment94441>
You should include a precondition check for desiredState being set or initialState being non-empty.
src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java
<https://reviews.apache.org/r/25953/#comment94443>
!isEmpty()
- Bill Farner
On Sept. 23, 2014, 8:38 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25953/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2014, 8:38 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-741
> https://issues.apache.org/jira/browse/AURORA-741
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added safety checks around initial/desired state presence and converted to left outer joins.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 361d3b8c0d59a0dad6b00c8a4b78ec8284383586
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 80535432c2c45eb2f3eb3bea4a797a99ea4fc2c9
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java aa7feb916f879f60d46ebaf53e47ba30d861c7fa
>
> Diff: https://reviews.apache.org/r/25953/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25953: Allow optional initial and desired states.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25953/
-----------------------------------------------------------
(Updated Sept. 23, 2014, 9:10 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
CR comments.
Bugs: AURORA-741
https://issues.apache.org/jira/browse/AURORA-741
Repository: aurora
Description
-------
Added safety checks around initial/desired state presence and converted to left outer joins.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 361d3b8c0d59a0dad6b00c8a4b78ec8284383586
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 80535432c2c45eb2f3eb3bea4a797a99ea4fc2c9
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java aa7feb916f879f60d46ebaf53e47ba30d861c7fa
Diff: https://reviews.apache.org/r/25953/diff/
Testing
-------
gradle -Pq build
Thanks,
Maxim Khutornenko