[GitHub] [lucene-solr] uschindler edited a comment on issue #889: LUCENE-8983: Add PhraseWildcardQuery to control multi-terms expansions in a phrase

[GitBox <gi...@apache.org>]

uschindler edited a comment on issue #889: LUCENE-8983: Add PhraseWildcardQuery to control multi-terms expansions in a phrase
URL: https://github.com/apache/lucene-solr/pull/889#issuecomment-554021084
 
 
   The current way how this is done (create the MultiTermQuery termsenum) is violating the API. The method MTQ#getTermsEnum is protected, so it should never ever called from the outside. Java just allows this from the same package, but it's just incorrect. protected methods should only be called from the class itsself and its subclasses.
   
   Expanding terms of a MTQ should be done by passing a RewriteMethod and then rewriting it (this still looks like a hack, but it's correct way). Some MTQ queryies may do some adjustments on rewrite.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org