[GitHub] [avro] clesaec commented on a diff in pull request #2405: AVRO-3818: [Rust] Let inner named types inherit their enclosing namespace if they have no their own namespace

["clesaec (via GitHub)" <gi...@apache.org>]

clesaec commented on code in PR #2405:
URL: https://github.com/apache/avro/pull/2405#discussion_r1278974077


##########
lang/rust/avro/src/schema.rs:
##########
@@ -1518,7 +1528,7 @@ impl Parser {
         }
 
         let schema = Schema::Enum(EnumSchema {
-            name,
+            name: fully_qualified_name.clone(),

Review Comment:
   Wouldn't it have been sufficient to ; keeping 
   `let fully_qualified_name = name.fully_qualified_name(enclosing_namespace);`
   without modifying Name::parse method ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org