[GitHub] [druid] jihoonson commented on issue #9564: Framework for aggregate testing; Example tests with LongSumAggregatorFactory

[GitBox <gi...@apache.org>]

jihoonson commented on issue #9564: Framework for aggregate testing; Example tests with LongSumAggregatorFactory
URL: https://github.com/apache/druid/pull/9564#issuecomment-604642637
 
 
   > however, even after this there is significant effort required to thoroughly test a new aggregator that only has even primitive type intermediate form :)
   
   @himanshug thanks for taking a look. Would you tell me more about this? I would like to make things better in this PR if possible.
   
   > FYI to contributors coming here: there is another common utility `AggregationTestHelper` that serves the purpose of writing tests that tries to simulate use of aggregator in real cluster .
   
   Thanks for pointing it out. My original intention was to add a low-level framework for aggregator testing without using the query framework (because it's high-level!), but I admit they are kind of similar. Let me check if they can be merged. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org