[GitHub] incubator-weex pull request #1216: [Weex-410][iOS] Fix gesture related crash...

[caixiaomin <gi...@git.apache.org>]

GitHub user caixiaomin opened a pull request:

    https://github.com/apache/incubator-weex/pull/1216

    [Weex-410][iOS] Fix gesture related crash on iOS8 with config

    1. All gesture recognizer delegate added to WXComponent should be set to nil on iOS8
    2. Provided a config to turn on/off, default is on

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/caixiaomin/incubator-weex FixGestureCrashOniOS8

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1216
    
----
commit afb5d95c45cddeddd2187bb6b2f42b6bea22fb9b
Author: Xiaomin <ca...@...>
Date:   2018-05-28T06:51:11Z

    [Weex-410][iOS] Add ext config removeEventsOfWXComponentWhenDealloc for fix gesture crash on iOS8

----


---

[GitHub] incubator-weex issue #1216: [Weex-410][iOS] Fix gesture related crash on iOS...

[weex-bot <gi...@git.apache.org>]

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1216
  
    
    <!--
      0 failure: 
      1 warning:  No Changelog chan...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---

[GitHub] incubator-weex pull request #1216: [Weex-410][iOS] Fix gesture related crash...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1216


---