[GitHub] incubator-hawq pull request #807: HAWQ-897. Add feature test for create tabl...

[hsyuan <gi...@git.apache.org>]

Github user hsyuan commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/807#discussion_r76184425
  
    --- Diff: src/test/feature/catalog/test_create_table.cpp ---
    @@ -22,26 +22,26 @@ class TestCreateTable : public ::testing::Test {
     TEST_F(TestCreateTable, TestCreateTable1) {
       hawq::test::SQLUtility util;
       // prepare
    -  util.execute("DROP TABLE IF EXISTS aggtest");
    --- End diff --
    
    The easier way to do this is creating a new schema `X`, set the default search_path to `X`. At the end of the test, drop the schema. In this way, you don't need to take care of dropping tables when you add new test cases. This is how GPDB is doing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---