You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "kazuyukitanimura (via GitHub)" <gi...@apache.org> on 2025/09/05 01:13:27 UTC
[I] TakeOrderedAndProjectExec is not reporting all fallback reasons [datafusion-comet]
kazuyukitanimura opened a new issue, #2311:
URL: https://github.com/apache/datafusion-comet/issues/2311
### Describe the bug
https://github.com/apache/datafusion-comet/blob/main/spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala#L384
TakeOrderedAndProjectExec fallback reasons are checked for
```
val info1 = createMessage(
!CometConf.COMET_EXEC_TAKE_ORDERED_AND_PROJECT_ENABLED.get(conf),
"TakeOrderedAndProject is not enabled")
val info2 = createMessage(
!isCometShuffleEnabled(conf),
"TakeOrderedAndProject requires shuffle to be enabled")
```
However
```
CometTakeOrderedAndProjectExec.isSupported(s)
```
condition is not checked. We should report which columns are unsupported as a part of fallback reasons
### Steps to reproduce
_No response_
### Expected behavior
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] TakeOrderedAndProjectExec is not reporting all fallback reasons [datafusion-comet]
Posted by "kazuyukitanimura (via GitHub)" <gi...@apache.org>.
kazuyukitanimura closed issue #2311: TakeOrderedAndProjectExec is not reporting all fallback reasons
URL: https://github.com/apache/datafusion-comet/issues/2311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org