You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2021/02/26 17:40:35 UTC

[GitHub] [madlib] reductionista opened a new pull request #556: Add -O0 if C++11 enabled

reductionista opened a new pull request #556:
URL: https://github.com/apache/madlib/pull/556


   There are some crashes we're seeing related to memory management when the C++11 flag is enabled.  It only happens when compiler optimizations are enabled, which makes it very difficult to debug.
   
   Since this is not an essential feature, and currently only works on OSX anyway, in the meantime we will simply disable compiler optimization for that case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [madlib] reductionista commented on pull request #556: Avoid using optimization -O2 or higher if C++11 is enabled

Posted by GitBox <gi...@apache.org>.
reductionista commented on pull request #556:
URL: https://github.com/apache/madlib/pull/556#issuecomment-796348743


   Without the cmake flag set, it passes all install-check and dev-check tests on these platforms:
   
   CentOS 6.10 / gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23) / cmake 3.5.2
   CentOS 6.10 / (GCC) 6.2.0, 64-bit / cmake 3.5.2
   Centos 7 / (GCC) 6.2.0, 64-bit / cmake 3.5.2
   Ubuntu 16 / gcc 6.2.0 / cmake 3.5.2
   Ubuntu 18 / gcc 6.2.0 / cmake 3.5.2
   MacOS Catalina / gcc  / cmake 
   MacOS Big Sur / gcc (Homebrew GCC 8.2.0) 8.2.0 / cmake 3.18.4
   
   With CXX11=1 set, it compiles and passes most of the install-check and dev-check tests on these platforms:
   
   CentOS 6.10 / gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23) / cmake 3.5.2
   CentOS 6.10 / (GCC) 6.2.0, 64-bit / cmake 3.5.2
   Centos 7 / (GCC) 6.2.0, 64-bit / cmake 3.5.2
   Ubuntu 16 / gcc 6.2.0 / cmake 3.5.2
   Ubuntu 18 / gcc 6.2.0 / cmake 3.5.2
   MacOS Big Sur / Apple clang version 12.0.0 (clang-1200.0.32.29) / cmake 3.18.4
   
   C++11 support is still "experimental" so we're okay for now with some tests failing for C++11 in kmeans, linalg, and recursive_partition.  Lowering the optimization helps get rid of some of them, but not all.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [madlib] reductionista merged pull request #556: Avoid using optimization -O2 or higher if C++11 is enabled

Posted by GitBox <gi...@apache.org>.
reductionista merged pull request #556:
URL: https://github.com/apache/madlib/pull/556


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org